twine check fails to prevent Invalid value for requires_dist. Error: Can't have direct dependency

[ssbarnea]

It seams that running twine check does not prevent upload errors like below:

HTTPError: 400 Bad Request from https://test.pypi.org/legacy/
Invalid value for requires_dist. Error: Can't have direct dependency: "ansible-core @ git+https://github.com/ansible/ansible.git ; extra == 'devel'"

This was caused by a package using the pep517 and a special extra that was used to install from git like below:

# setup.cfg
[options.extras_require]
devel =
  ansible-core @ git+https://github.com/ansible/ansible.git  # GPLv3+

This worked well with pip and with tox and passed the packaging testing, but failed when the tagged release was uploading.

This seams related to pypa/pip#6301 but it is not clear from it who is really to be blame.

Because this currently fails it would be very useful to improve the check feature in twine to detect this issue before we make a release.

[di]

Duplicate of #430 I think.

[sigmavirus24]

@di on the nose

[abitrolly]

I've got the same error. Does that mean PyPI doesn't support URLs in dependencies at all? I could not find anything in documentation. https://pypi.org/help/

[abitrolly]

Found the reference in PEP-0440.

Public index servers SHOULD NOT allow the use of direct references in uploaded distributions. Direct references are intended as a tool for software integrators rather than publishers.