Add --ignore-http-status option #1271
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is effectively a replacement for --skip-existing with non-PyPI repositories. It is not allowed when using [Test]PyPI, and is instead a way for users of other repositories to choose which status(es) can be ignored. This commit also rewords the UnsupportedConfiguration message a bit; instead of asserting that the configured repository does not support a particular feature (which is not actually checked), instead assert that Twine does not support using the feature(s) with the configured repository.
zware
force-pushed
the
ignore_http_opt
branch
from
c421440 to
f99c568
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is effectively a replacement for --skip-existing with non-PyPI
repositories. It is not allowed when using [Test]PyPI, and is instead a
way for users of other repositories to choose which status(es) can be
ignored.
This commit also rewords the UnsupportedConfiguration message a bit;
instead of asserting that the configured repository does not support a
particular feature (which is not actually checked), instead assert that
Twine does not support using the feature(s) with the configured
repository.
This option is technically complementary to #1270; the two don't really have anything to do with each other other than offering a way to get around the non-PyPI
--skip-existingissue, but this one seems less prone to being a slippery slope and offers a solution for users of repositories that don't act enough like PyPI. Overall I think I prefer this approach, and if accepted I would abandon #1270.