-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update changelog and bump version for new release #306
Conversation
Codecov Report
@@ Coverage Diff @@
## master #306 +/- ##
=======================================
Coverage 67.42% 67.42%
=======================================
Files 12 12
Lines 574 574
Branches 91 91
=======================================
Hits 387 387
+ Misses 162 161 -1
- Partials 25 26 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me. I don’t have anything to add. Best of luck!
Please let's not use GitHub releases. They don't scale. They require manual process. They require people to upload binaries and as soon as one appears, downstream redistributors expect them to always be updated. They also hide the "releases" created by simply pushing tags. They confuse users. They're all around awful unless we're very consistent with them. |
OK! So I will figure out a git tag instead. Haven't done that before so any "here is how we do it" guidance is welcome. @sigmavirus24 if you could add |
|
I can add you later tonight |
I added you to the package on testpypi and pypi. Would [testenv:release]
# ..
commands =
python setup.py -q bdist_wheel sdist
twine upload --skip-existing {posargs} dist/ That would allow you to pass signing options to it. I'm not sure we need to upload signed packages for twine. Warehouse doesn't use the signatures or expose them for users to view. My last item is the following: There are a lot of very large projects and companies that rely on Twine. We obviously can't catch every regression or bug, so releasing on the weekend (or right before) is really inconvenient for those users. If at all possible, we should release on Monday or Tuesdays. |
Thanks @sigmavirus24. I'll use the
I know that right now Warehouse does not use or expose the signatures, but I am rather attached to signing packages for what I will freely admit are not-very-defensible hindbrain reasons ("but it's more secure!!1!"). So I'd appreciate the And you're right, releasing on a Friday is setting myself up for headaches. I'll release to Test PyPI today to test the process, and then Monday or Tuesday I'll release 1.10.0 onto canon PyPI. |
I will present the following case for not signing twine releases: There are three maintainers with three separate GPG keys and downstream redistributors, for however much they mean well, will throw tantrums if each of us releases and signs twine differently every time. Somehow, this always upsets them. I'd rather not lull them into a sense of us always signing releases, nor signing them with the same key. I'd be interested to see what including that whole message in the release tag message does. I've no evidence that anyone actually reads it. I'm also not certain that GitHub will display it for us. It will be interesting to see what the results of your experimentation are. :) |
I think gpg signing on PyPI is a net negative for the ecosystem and I want very much to eliminate it. |
Understood. Thank you both. I shall refrain from signing this and other Twine releases. |
As a new maintainer of twine, here's what I believe I have to do in order to make a new release of twine. Please correct me if I'm wrong and tell me if I'm right.
docs/changelog.rst
with the newest changes (done in Update changelog #308) and the new release (done in this PR)__version__
string intwine/__init__.py
python setup.py check -r -s
to check that thelong_description
and other metadata will render finetox -e py{27,34,25,36}
andtox -e pep8
to check tests haven't broken (I did this with all but Python 3.4, which I don't have installed yet)python setup.py sdist bdist_wheel
keyring
(need privileges, usernamebrainwane
)twine upload --repository-url https://test.pypi.org/legacy/ --skip-existing dist/*
keyring
(need privileges, usernamebrainwane
)twine upload --skip-existing dist/*
(to someday in the future be superseded bytox -e release
)pypa-announce
(need to subscribe and then get posting privileges)