Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .pypirc section to the README #340

Closed
wants to merge 1 commit into from
Closed

Conversation

felipedau
Copy link

This PR was made with the first item from #11 in mind and intends to close #118.

I am still not sure if we should even mention that people can store passwords in that file, but I chose to tell what they can do and let them decide what's best for them. I would totally agree if you preferred to just mention the url and username to make the section simpler.

Other docs that I think we could improve are:

Let me know what you think!

@codecov
Copy link

codecov bot commented Apr 9, 2018

Codecov Report

Merging #340 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #340   +/-   ##
=======================================
  Coverage   69.55%   69.55%           
=======================================
  Files          12       12           
  Lines         588      588           
  Branches       93       93           
=======================================
  Hits          409      409           
  Misses        150      150           
  Partials       29       29

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dcc6375...edb2e55. Read the comment docs.

@sigmavirus24
Copy link
Member

I think it makes more sense to include this in our real documentation and not in the README. What do you think @brainwane ?

@joshuarli
Copy link

Instead of adding this to the README or the official twine docs, and having to maintain separate .pypirc documentation, why not just add a link to the official distutils docs as originally suggested by #11, and mention that twine can also parse .pypirc for configuration?

@felipedau
Copy link
Author

I agree with you @sigmavirus24 and @joshuarli. I thought that it was supposed to be a section just like the keyring one. Should we wait for @brainwane's opinion or go ahead and change it?

One other thing I think we should do is mentioning twine in the official docs and possibly suggest the use of keyring. What do you think?

@brainwane
Copy link
Contributor

I'd love for folks to update the official distutils docs (including pointing to Twine, if they're ok with that) and then point to that from the Twine README and ReadTheDocs docs!

@theacodes
Copy link
Member

I'm -1 on having this in the readme, and agree that we should just fix the upstream docs. I'll make a note for myself to do that, but if someone wants to beat me to it, go for it!

@di
Copy link
Member

di commented Sep 14, 2018

I think we probably should operate under the assumption that the distutils docs are going to go away in the future, and that the documentation at https://packaging.python.org/ will outlive them.

@theacodes
Copy link
Member

theacodes commented Sep 14, 2018 via email

@theacodes
Copy link
Member

Okay, I'm -1 on this PR, it seems the right place to document this is packaging.python.org. If anything, this should just link to those docs.

I'm going to go ahead and close this, but we can continue to discuss / move this to packaging.python.org.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mention that twine prompts you for credentials when omitted
6 participants