Feature/verify ssl flag #536
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for those without valid certificates who wish to use twine nonetheless
for those without valid certificates who wish to use twine nonetheless
jaraco
reviewed
Nov 14, 2019
| "-v", "--verify", | ||
| default=True, | ||
| required=False, | ||
| action="store_false", |
There was a problem hiding this comment.
This usage seems counter-intuitive to me. If I understand correctly, passing --verify will disable verification. Probably better would be --verify={yes/on/true,no/off/false} and have a default (yes).
jaraco
reviewed
Nov 14, 2019
| default=True, | ||
| required=False, | ||
| action="store_false", | ||
| help="Upload with or without SSL verification." |
There was a problem hiding this comment.
Please always include a trailing slash.
Suggested change
| help="Upload with or without SSL verification." | |
| help="Upload with or without SSL verification.", |
jaraco
requested changes
Nov 14, 2019
jaraco
requested changes
Nov 14, 2019
|
This looks similar to PR #463. However, @di expressed some concerns about that in the original issue: #387 (comment). |
di
reviewed
Nov 15, 2019
There was a problem hiding this comment.
I'm -1 on this change for the same reasons listed in #387 (comment). Twine shouldn't be providing a crutch to broken/insecure/misconfigured systems.
|
I'll close this pr, It's simillar to #463, sorry for that. |
James-E-A
added a commit
to James-E-A/pypa-twine
that referenced
this pull request
Feb 1, 2024
The lack of this has been a *perennial* thorn for people behind corporate TLS MITM ALG proxies; when it's soluble, it's still annoying, and sometimes the proxy applications don't use a stable root bundle, rendering the situation kinda insoluble. - pypa#328 - pypa#387 - pypa#536 - pypa#740 - pypa#741 - pypa#835 - pypa#915 - pypa#1025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds verify_ssl flag to indicates if ssl certificate verification is needed (default is True)