Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error message for unsupported metadata #755

Merged
merged 2 commits into from
May 29, 2021
Merged

Improve error message for unsupported metadata #755

merged 2 commits into from
May 29, 2021

Conversation

bhrutledge
Copy link
Contributor

Related to #753, hopefully to give a little more clarity about the underlying issue. Feedback welcome on the wording.

@bhrutledge bhrutledge requested a review from di May 18, 2021 01:12
@bhrutledge
Copy link
Contributor Author

@di Any thoughts on this?

di
di approved these changes May 26, 2021
View reviewed changes
Copy link
Member

@di di left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it'd be more helpful if pkginfo was able to tell us what version it thought was invalid, but that doesn't seem possible so this is probably the best we can do.

@bhrutledge bhrutledge merged commit 7acd94e into pypa:master May 29, 2021
@bhrutledge bhrutledge deleted the 753-metadata-error branch May 29, 2021 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@di di di approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bhrutledge @di