Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in setup.cfg #1858

Merged
merged 1 commit into from
Jun 12, 2020
Merged

Fix typo in setup.cfg #1858

merged 1 commit into from
Jun 12, 2020

Conversation

RowdyHowell
Copy link
Contributor

@RowdyHowell RowdyHowell commented Jun 12, 2020

Closes #1857

  • ran the linter to address style issues (tox -e fix_lint)
  • wrote descriptive pull request text
  • ensured there are test(s) validating the fix
  • added news fragment in docs/changelog folder
  • updated/extended the documentation

@codecov
Copy link

codecov bot commented Jun 12, 2020

Codecov Report

Merging #1858 into master will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1858      +/-   ##
==========================================
- Coverage   88.84%   88.77%   -0.08%     
==========================================
  Files          82       82              
  Lines        3946     3946              
==========================================
- Hits         3506     3503       -3     
- Misses        440      443       +3     
Flag Coverage Δ
#tests 88.77% <ø> (-0.08%) ⬇️
Impacted Files Coverage Δ
src/virtualenv/seed/embed/wheels/__init__.py 100.00% <ø> (ø)
src/virtualenv/run/app_data.py 91.66% <0.00%> (-5.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55b4547...f3b8094. Read the comment docs.

Copy link

@semoac semoac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pascal-de-ladurantaye
Copy link

@gaborbernat please LGTM

@neongazer
Copy link

LGTM!

@gaborbernat gaborbernat merged commit 95ae467 into pypa:master Jun 12, 2020
Copy link

@sdpak sdpak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good. Thanks

@gaborbernat
Copy link
Contributor

Give me 5 mintues.

@gaborbernat
Copy link
Contributor

Sorry for that guys, my mistake, fix out under https://pypi.org/project/virtualenv/20.0.23/

@RowdyHowell RowdyHowell deleted the patch-1 branch June 12, 2020 19:14
@fj-sanchez
Copy link

Doesn't look that good to me... the fact that a test hasn't been introduced won't stop this from happening again.

@GPHemsley
Copy link

@fj-sanchez The entire testsuite failed because of this bug, and it was still released; adding another test isn't gonna make much difference...

@fj-sanchez
Copy link

Ok, I didn't realise that was the case. Why isn't enforced a pass on all the tests?

@rowanseymour
Copy link

I think this makes a nice case study in why it's good practice to do automated releases from CI.. after tests pass

@gaborbernat
Copy link
Contributor

Just to sum up the discussion:

  • This repository has the release process automated and happens automatically on the tag after tests pass.
  • However, a CI run takes fairly long: 25-30 minutes.
  • There was a PR that upgraded the embedded versions that passed. It lacked the changelog entries for. So decided to add them, and append it. While doing this change by mistake the setup.cfg got modified. This project is maintained completely in the free and voluntary time of maintainers (which at the moment involves just me). Someone requested a release to fix issues generated by the release of importlib.metadata v2. At this point was 7pm local time on a Friday, and considering my available time was running to an end I decided to expedite the release by force-merging the PR and the release. In hindsight, this was obviously a bad idea; but the reason for it was my intent to accommodate a release quicker.

I'm deeply sorry that this affected everyone's Friday, lessons learned and hope this will not happen again going ahead. Just for context, this was my 42nd release of this project throughout the last 2 years. I think this was the first truly broken release and hope to stay as such for at least another 100.

@pypa pypa locked as resolved and limited conversation to collaborators Jun 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AttributeError: module 'virtualenv.activation.python' has no attribute 'PestythonActivator'
9 participants