-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use unix line-endings in bash activate script #1924
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1924 +/- ##
==========================================
- Coverage 93.98% 93.96% -0.02%
==========================================
Files 86 86
Lines 4221 4225 +4
==========================================
+ Hits 3967 3970 +3
- Misses 254 255 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
saytosid
force-pushed
the
fix/1818
branch
4 times, most recently
from
August 16, 2020 11:53
4246291
to
446d93e
Compare
gaborbernat
reviewed
Aug 17, 2020
Signed-off-by: Siddhant Kumar <skumar619@bloomberg.net>
Signed-off-by: Bernat Gabor <bgabor8@bloomberg.net>
Signed-off-by: Bernat Gabor <bgabor8@bloomberg.net>
Signed-off-by: Bernat Gabor <bgabor8@bloomberg.net>
gaborbernat
force-pushed
the
fix/1818
branch
4 times, most recently
from
August 21, 2020 09:49
47dadfb
to
ebe560c
Compare
Signed-off-by: Bernat Gabor <bgabor8@bloomberg.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1818
Signed-off-by: Siddhant Kumar skumar619@bloomberg.net
Thanks for contributing, make sure you address all the checklists (for details on how see
development documentation)!
tox -e fix_lint
)docs/changelog
folder- [ ] updated/extended the documentation- N/A, this is a bug fix