Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix activator path in cygwin and msys2 #1952

Merged
merged 1 commit into from
Sep 30, 2020
Merged

Fix activator path in cygwin and msys2 #1952

merged 1 commit into from
Sep 30, 2020

Conversation

danyeaw
Copy link
Contributor

@danyeaw danyeaw commented Sep 26, 2020

Closes #1940. In cygwin and MSYS2, the path is in POSIX format. This PR converts the Windows path to POSIX format using a regex so that it is added to the bash activation script in the correct format.

Thanks for contributing, make sure you address all the checklists (for details on how see

development documentation)!

  • ran the linter to address style issues (tox -e fix_lint)
  • wrote descriptive pull request text
  • ensured there are test(s) validating the fix
  • added news fragment in docs/changelog folder
  • updated/extended the documentation

@codecov
Copy link

codecov bot commented Sep 26, 2020

Codecov Report

Merging #1952 into main will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1952      +/-   ##
==========================================
- Coverage   93.92%   93.91%   -0.02%     
==========================================
  Files          86       86              
  Lines        4228     4237       +9     
==========================================
+ Hits         3971     3979       +8     
- Misses        257      258       +1     
Flag Coverage Δ
#tests 93.91% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/virtualenv/activation/via_template.py 100.00% <100.00%> (ø)
src/virtualenv/seed/embed/base_embed.py 96.22% <0.00%> (-1.89%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bcf20e...927aa92. Read the comment docs.

@danyeaw danyeaw changed the title Fix activator path in cygwin and msys2 [WIP] Fix activator path in cygwin and msys2 Sep 26, 2020
@danyeaw danyeaw changed the title [WIP] Fix activator path in cygwin and msys2 Fix activator path in cygwin and msys2 Sep 26, 2020
Closes #1940. In cygwin and MSYS2, the path is in POSIX format.
This PR converts the Windows path to POSIX format using a regex
so that it is added to the bash activation script in the correct
format.
@danyeaw
Copy link
Contributor Author

danyeaw commented Sep 29, 2020

Anything else needed on this one?

@gaborbernat gaborbernat merged commit 5e46e4a into pypa:main Sep 30, 2020
@danyeaw danyeaw deleted the msys2-fix branch September 30, 2020 09:48
@danyeaw
Copy link
Contributor Author

danyeaw commented Sep 30, 2020

Thanks @gaborbernat !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cygwin and msys2 bash activator compatibility
2 participants