Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes issue with activate.fish on OSX #207

Closed
wants to merge 4 commits into from
Closed

Fixes issue with activate.fish on OSX #207

wants to merge 4 commits into from

Conversation

dsc
Copy link

@dsc dsc commented Dec 23, 2011

Fixes #8, as tempfile doesn't exist on OSX (also without getting messy with mktemp).

@dsc
Copy link
Author

dsc commented Dec 23, 2011

ps. I didn't run bin/rebuild-script.py before check-in. I wasn't really sure how you guys handle that.

@carljm
Copy link

carljm commented Mar 14, 2012

Yeah, the problem is that bin/refresh-support-files.py updates ez_setup.py from the canonical version, but our version has been updated to make it syntactically compatible with Python 3 (just so installation of virtualenv doesn't break, not that ez_setup.py will actually be run under Python 3, since setuptools doesn't support it). So that change has to be reverted after running refresh-support-files.py. Really we should just remove ez_setup.py from refresh-support-files.py.

@carljm
Copy link

carljm commented Apr 3, 2012

Merged (using squash, so I could clean up the ez_setup.py stuff) in 9be1f43 - thanks @dsc.

@carljm carljm closed this Apr 3, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dsc @carljm @gregglind