Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Omit backports.entry_points_selectable for Python >=3.10 #2238

Closed
wants to merge 1 commit into from
Closed

Omit backports.entry_points_selectable for Python >=3.10 #2238

wants to merge 1 commit into from

Conversation

Chocimier
Copy link

If I understood backports.entry_points_selectable documentation correctly, this is equivalent.
Change is proposed to update above 20.4.7 on Void Linux, which is on python 3.10 already, without fuss of adding the backport module to repository.

  • ran the linter to address style issues (tox -e fix_lint)
  • wrote descriptive pull request text
  • ensured there are test(s) validating the fix
  • added news fragment in docs/changelog folder
  • updated/extended the documentation

@hroncok
Copy link
Contributor

hroncok commented Dec 3, 2021

Thank you!

@@ -0,0 +1 @@
Omit backports.entry_points_selectable for Python >=3.10
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add this as a feature please and not misc; misc basically reserved for project maintenance files only, not that affects code.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, can we drop backports.entry_points_selectable entirely here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose we can if we require importlib-metadata>=3.6;python_version<"3.10" and do:

if sys.version_info >= (3, 10):
    from importlib.metadata import entry_points
else:
    from importlib_metadata import entry_points

-- not sure if that is much better.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternatively can we use the old API on old pythons and the new API on new Pythons? Rather than try to use the same?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like this? #2241

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added as feature. The other PR would fit my needs as well.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer 2241, so will be closing this.

@gaborbernat gaborbernat closed this Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants