Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to be a separate issue with Windows PyPy 3.6
I ran
tests/unit/create/test_creator.py
in Windows PyPy 3.6 (v7.3.3) and got errors in the same tests as CI, excepttest_create_distutils_cfg[venv]
that passes locally and fails on CI, most likely due to timeout.Local tests fails when the
test_create_no_seed[venv*]
checks exe files, but CI errors causes when same tests find an exception increator.debug
:The
SyntaxError
was happened increator.py
because ofliteral_eval(out)
whenout
is empty.I can't reproduce the exception locally, but I modified the debug info to look something like:
Windows PyPy <= 3.6 contains only
pypy3.exe
andpypy3w.exe
and creating a virtual environment withvenv
does not hanlde missing executables, e.g.python.exe
. Also, thestdlib
path for old PyPy versions is<host>\site-packages
instead of<host>\Lib\site-packages
.Local tests failures are fixed by creating missing executables.
Test coverage calculation is fixed by adding
stdlib
path for old PyPy versions into.coveragerc
sources.