Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Nushell activation script to module #2422

Merged
merged 7 commits into from
Nov 27, 2022
Merged

Change Nushell activation script to module #2422

merged 7 commits into from
Nov 27, 2022

Conversation

kubouch
Copy link
Contributor

@kubouch kubouch commented Sep 17, 2022 •
edited
Loading

Description

The activation script will be a module that would be added as an overlay which allows for more ergonomic handling of the environment varaibles.

I had to change the source activation command to overlay use because that's how you activate overlay in Nushell. However, it required me to also disable quoting of the command. By default, the Python activator would create 'overlay use' and try to call that as a command but in Nushell, commands are called without quotes.

Thanks for contributing, make sure you address all the checklists (for details on how see development documentation)!

  • ran the linter to address style issues (tox -e fix_lint)
  • wrote descriptive pull request text
  • ensured there are test(s) validating the fix
  • added news fragment in docs/changelog folder
  • updated/extended the documentation

@kubouch kubouch marked this pull request as draft September 17, 2022 20:28
@kubouch kubouch marked this pull request as ready for review September 17, 2022 21:05
@kubouch kubouch marked this pull request as draft September 17, 2022 21:33
This was referenced Sep 20, 2022
Merged
Closed
Closed
@gaborbernat
Copy link
Contributor

@kubouch shall we proceed here?

@kubouch
Copy link
Contributor Author

kubouch commented Oct 25, 2022

Yes, this is still intended to be merged, I just didn't find the time to finish the activation command being a list.

@gaborbernat gaborbernat marked this pull request as ready for review November 27, 2022 18:38
@gaborbernat gaborbernat merged commit ffa04ae into pypa:main Nov 27, 2022
github-actions bot added a commit to MaRDI4NFDI/open-interfaces that referenced this pull request Nov 28, 2022
@github-actions
⬆️ Bump virtualenv from 20.16.7 to 20.17.0 (#141)
5a110b1 
Bumps [virtualenv](https://github.com/pypa/virtualenv) from 20.16.7 to
20.17.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/pypa/virtualenv/releases">virtualenv's
releases</a>.</em></p>
<blockquote>
<h2>20.17.0</h2>
<h2>What's Changed</h2>
<ul>
<li>release 20.16.7 by <a
href="https://github.com/gaborbernat"><code>@​gaborbernat</code></a> in
<a
href="https://github-redirect.dependabot.com/pypa/virtualenv/pull/2445">pypa/virtualenv#2445</a></li>
<li>Change Nushell activation script to module by <a
href="https://github.com/kubouch"><code>@​kubouch</code></a> in <a
href="https://github-redirect.dependabot.com/pypa/virtualenv/pull/2422">pypa/virtualenv#2422</a></li>
<li>Fix operator in Nushell activation script by <a
href="https://github.com/kubouch"><code>@​kubouch</code></a> in <a
href="https://github-redirect.dependabot.com/pypa/virtualenv/pull/2450">pypa/virtualenv#2450</a></li>
<li>Do not use deprecated API by <a
href="https://github.com/gaborbernat"><code>@​gaborbernat</code></a> in
<a
href="https://github-redirect.dependabot.com/pypa/virtualenv/pull/2448">pypa/virtualenv#2448</a></li>
<li>Bump setuptools by <a
href="https://github.com/gaborbernat"><code>@​gaborbernat</code></a> in
<a
href="https://github-redirect.dependabot.com/pypa/virtualenv/pull/2451">pypa/virtualenv#2451</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/pypa/virtualenv/compare/20.16.7...20.17.0">https://github.com/pypa/virtualenv/compare/20.16.7...20.17.0</a></p>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a
href="https://github.com/pypa/virtualenv/blob/main/docs/changelog.rst">virtualenv's
changelog</a>.</em></p>
<blockquote>
<h2>v20.17.0 (2022-11-27)</h2>
<p>Features - 20.17.0</p>
<pre><code>- Change Nushell activation script to be a module meant to be
activated as an overlay.
(`[#2422](pypa/virtualenv#2422)
&lt;https://github.com/pypa/virtualenv/issues/2422&gt;`_)
- Update operator used in Nushell activation script to be compatible
with future versions.
(`[#2450](pypa/virtualenv#2450)
&lt;https://github.com/pypa/virtualenv/issues/2450&gt;`_)
<p>Bugfixes - 20.17.0
</code></pre></p>
<ul>
<li>Do not use deprecated API from <code>importlib.resources</code> on
Python 3.10 or later - by :user:<code>gaborbernat</code>.
(<code>[#2448](pypa/virtualenv#2448)
&lt;https://github.com/pypa/virtualenv/issues/2448&gt;</code>_)</li>
<li>Upgrade embedded setuptools to <code>65.6.3</code> from
<code>65.5.1</code> - by :user:<code>gaborbernat</code>.
(<code>[#2451](pypa/virtualenv#2451)
&lt;https://github.com/pypa/virtualenv/issues/2451&gt;</code>_)</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/pypa/virtualenv/commit/33e7b9db29e93493e695f929767a27f007d31f4c"><code>33e7b9d</code></a>
release 20.17.0</li>
<li><a
href="https://github.com/pypa/virtualenv/commit/7cb7e63e749c17a9b8e2d37616189f5d9e079251"><code>7cb7e63</code></a>
Bump setuptools (<a
href="https://github-redirect.dependabot.com/pypa/virtualenv/issues/2451">#2451</a>)</li>
<li><a
href="https://github.com/pypa/virtualenv/commit/9bc1f9fb98fe2766a4f2c69f9738f89e3ce2cef0"><code>9bc1f9f</code></a>
Do not use deprecated API (<a
href="https://github-redirect.dependabot.com/pypa/virtualenv/issues/2448">#2448</a>)</li>
<li><a
href="https://github.com/pypa/virtualenv/commit/4961931fe6497efb619f21983a8da4ee9ef04240"><code>4961931</code></a>
Fix operator in Nushell activation script (<a
href="https://github-redirect.dependabot.com/pypa/virtualenv/issues/2450">#2450</a>)</li>
<li><a
href="https://github.com/pypa/virtualenv/commit/ffa04ae837c1821a118ca501180005e85cc40d08"><code>ffa04ae</code></a>
Change Nushell activation script to module (<a
href="https://github-redirect.dependabot.com/pypa/virtualenv/issues/2422">#2422</a>)</li>
<li><a
href="https://github.com/pypa/virtualenv/commit/e6925a6afbb88fdaa7af9e57016f8c53c4359aee"><code>e6925a6</code></a>
Merge pull request <a
href="https://github-redirect.dependabot.com/pypa/virtualenv/issues/2445">#2445</a>
from pypa/release-20.16.7</li>
<li>See full diff in <a
href="https://github.com/pypa/virtualenv/compare/20.16.7...20.17.0">compare
view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=virtualenv&package-manager=pip&previous-version=20.16.7&new-version=20.17.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>
@andytom andytom mentioned this pull request Jan 1, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaborbernat gaborbernat gaborbernat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kubouch @gaborbernat