Fix Nushell installation failures #2475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is a failure on MacOS but it seems unrelated to the changes I made. |
|
OK, I'm falling back to using choco and brew on Windows & Mac so this PR affects only the Linux tests. |
gaborbernat
approved these changes
Dec 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the Nushell installation method to use https://github.com/marketplace/actions/install-development-tools which in turn uses cargo binstall to install Nushell binary directly from GitHub releases. Unlike the previous method which points at https://api.github.com/repos/nushell/nushell/releases/latest this one should point at the build artifacts directly and hopefully avoids the 403 problems.
Also makes the CI script simpler.
Thanks for contributing, make sure you address all the checklists (for details on how see development documentation)!
tox -e fix_lint)docs/changelogfolder