Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update nushell's str collect command to str join #2532

Merged
merged 4 commits into from
Mar 31, 2023
Merged

update nushell's str collect command to str join #2532

merged 4 commits into from
Mar 31, 2023

Conversation

fdncred
Copy link
Contributor

@fdncred fdncred commented Mar 30, 2023

We've deprecated the nushell command str collect a few months ago. We've replaced it with str join. This PR makes these changes in the activate.nu script.

Thanks for contributing, make sure you address all the checklists (for details on how see development documentation)

  • ran the linter to address style issues (tox -e fix)
  • wrote descriptive pull request text
  • ensured there are test(s) validating the fix
  • added news fragment in docs/changelog folder
  • updated/extended the documentation

@fdncred
Copy link
Contributor Author

fdncred commented Mar 31, 2023

These CI failures seem unrelated to this PR. Could someone please take a look?

BTW - One macos test failed yesterday due to timeout. I pushed an empty commit this morning to try and get it to rerun. That's when this other test failure showed up. It's looking like check / test pypy-3.8 - macos-12 is going to fail/timeout again since it's been running more than 1.5 hours now.

@fdncred
Copy link
Contributor Author

fdncred commented Mar 31, 2023

Thanks @gaborbernat!!

@gaborbernat gaborbernat merged commit 02585da into pypa:main Mar 31, 2023
@fdncred fdncred deleted the update_deprected_str_collect branch March 31, 2023 16:59
tarpas pushed a commit to tarpas/virtualenv that referenced this pull request Jun 8, 2023
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants