Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix windows utf8 encoding issue #2687

Merged
merged 2 commits into from
Mar 22, 2024
Merged

Conversation

PzaThief
Copy link
Contributor

@PzaThief PzaThief commented Feb 5, 2024

Batch and Powershell do not work properly if non-ASCII text (e.g. "аạąäàáą") is used in the folder name or prompt name.
For Batch case, there is a codepage issue under the problem and cpython's venv has the solution already.
And Powershell assumes Windows 1252 encoding when reading files without BOM. So I added Bom using utf-8-sig encoding.

Batch error screenshot (see broken prompt name after activate)
Batch error screenshot

Powershell error screenshot
Powershell error screenshot

Copy link
Contributor

@gaborbernat gaborbernat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is failing.

@gaborbernat gaborbernat marked this pull request as draft February 21, 2024 21:32
@PzaThief PzaThief marked this pull request as ready for review February 23, 2024 02:54
Copy link
Contributor

@gaborbernat gaborbernat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests please.

@PzaThief
Copy link
Contributor Author

Tests please.

Sorry for late.
I fixed test failing now. could you check CI again?

@gaborbernat gaborbernat merged commit e62efdb into pypa:main Mar 22, 2024
45 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants