Avoid importing contextlib in _virtualenv
#2688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This was introduced in #2588 , presumably as part of a mass application of SIM105 |
|
Looks like tests are failing on #2685 as well... |
|
(Also noob question: what is the |
Probably a no-op, could try removing it. |
hauntsaninja
added a commit
to hauntsaninja/uv
that referenced
this pull request
Feb 16, 2024
No need to pay 3ms on basically every Python invocation. I opened a PR upstream last week: pypa/virtualenv#2688
charliermarsh
pushed a commit
to astral-sh/uv
that referenced
this pull request
Feb 16, 2024
No need to pay 3ms on basically every Python invocation. I opened a PR upstream last week: pypa/virtualenv#2688
This appears to be imported in a `.pth` file, so this file runs in basically every Python program in my environment. contextlib takes about 3ms to import and I'd prefer to not pay that cost if not strictly necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This appears to be imported in a
.pthfile, so this file runs in basically every Python program in my environment. contextlib takes about 3ms to import and I'd prefer to not pay that cost if not strictly necessary.Thanks for contributing, make sure you address all the checklists (for details on how see development documentation)
tox -e fix)docs/changelogfolder