Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

egg2dist solicits distinfo_path from two places #206

Closed
jaraco opened this issue Nov 12, 2017 · 2 comments
Closed

egg2dist solicits distinfo_path from two places #206

jaraco opened this issue Nov 12, 2017 · 2 comments
Milestone

Comments

@jaraco
Copy link
Member

jaraco commented Nov 12, 2017

Discovered in pypa/setuptools#1196, it seems that the egg2dist function both accepts a parameter distinfo_path but also accesses self.distinfo_dir. When egg2dist is invoked from an external caller like setuptools, and distinfo_dir isn't set, and the license text functionality is triggered, the function will crash with a TypeError.

egg2dist should either only use distinfo_path passed as a parameter or use the instance attribute. Even better, if possible, egg2dist should be refactored such that it doesn't depend on instance attributes at all (and thus can be a classmethod).

@agronholm
Copy link
Contributor

It should be noted that wheel does not have a public API. If you import wheel code directly, it may break in the next release.

@agronholm
Copy link
Contributor

I'll get this fixed for the next release, if possible. I'm doing a rather large refactoring of the code base now.

@agronholm agronholm added this to the 0.31 milestone Mar 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants