Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use regular PEP 425 interpreter tags for PyPy wheels #329

Closed
ncoghlan opened this issue Jan 27, 2020 · 2 comments
Closed

Use regular PEP 425 interpreter tags for PyPy wheels #329

ncoghlan opened this issue Jan 27, 2020 · 2 comments

Comments

@ncoghlan
Copy link
Member

We'd like to go back to using standard PEP 425 tags for PyPy wheels (see pypa/packaging#233 and pypa/pip#7629), but that entails having PyPy build wheels with the regular leading interpreter tag, rather than the current PyPy specific one.

I'm working on a PR to temporarily add back support for the custom tags to pip, but would also like to contain the problem on the wheel side, and will post a PR for that shortly.
@ncoghlan ncoghlan mentioned this issue Jan 27, 2020
Closed
@mattip
Copy link
Contributor

mattip commented Jan 27, 2020

How does this relate to issue gh-328 and the pypytags branch? I think @agronholm was going to merge that and release

@ncoghlan
Copy link
Member Author

Turns out this is a duplicate of #328, but there's still a remnant of the old custom PyPy tagging in the code (it just doesn't do anything meaningful any more).

I noticed the duplication when I went to add a NEWS entry.

ncoghlan added a commit to ncoghlan/wheel that referenced this issue Jan 27, 2020
@ncoghlan
Issue pypa#329: Remove last remnant of custom PyPy tags
87bc129 
The resolution of issue pypa#328 removed the custom PyPy tagging
from `get_impl_version_info()`, this just cleans up the check
that forces PyPy to call that even if `py_version_nodot` was
already set.
@ncoghlan ncoghlan mentioned this issue Jan 27, 2020
Merged
agronholm pushed a commit that referenced this issue Jan 27, 2020
@ncoghlan @agronholm
Issue #329: Remove last remnant of custom PyPy tags (#330)
ca44496 
The resolution of issue #328 removed the custom PyPy tagging
from `get_impl_version_info()`, this just cleans up the check
that forces PyPy to call that even if `py_version_nodot` was
already set.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mattip @ncoghlan