-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switched build backend to flit #436
Conversation
Codecov Report
@@ Coverage Diff @@
## main #436 +/- ##
=======================================
Coverage 67.57% 67.57%
=======================================
Files 12 12
Lines 916 916
=======================================
Hits 619 619
Misses 297 297 Continue to review full report at Codecov.
|
It seems there is no way to have flit add a |
Now that I have ditched flit-scm for flit_core, is this now good to go? |
I'll just note that redistributors would have to install flit in addition to flit_core to be able to build a wheel sdist with Something to watch out for is that flit has different package data inclusion criteria for packages built with Footnotes
|
I am slowly being driven crazy by all these constraints. As for downstream packagers, the only consistent way to get their attention is by breaking something, and that is never a pleasant situation. That said, we do need to move to standardized packaging and I fear that many downstream packagers won't bother to do the migration work until they absolutely must. Still, I think it would be prudent to open a discussion at discuss.python.org to collect feedback about the planned build configuration changes. |
Not just you 😛 |
FYI, the bootstrapping story should be much better now: pypa/build#394 (comment) (Though build is not converted yet, I'll try to get to that soonish) |
Also packaging which is in the dependency tree of build needs to be converted as well. |
hooks: | ||
- id: flake8 | ||
- id: pyproject-flake8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI, Anthony and co. actively fight others adding pyproject.toml support as well, see csachs/pyproject-flake8#13. Currently broken with Flake8 5 though might be fixable for now.
FYI, Packaging and Build have both moved to Flit. Noticed the circular dependency issue in the last release, which Flit would solve. |
Yeah, packaging still needs a new release with flit support from what I can tell however(I see build got one a few days ago). |
Build's 0.9.0 release was right before the Flit transition. We are thinking about doing one soon-ish with the new system, but I'm not sure there's a rush until there's a packaging release. |
Ah, yeah, just noticed that. |
Both build and packaging have released with flit as build backend. |
This allows wheel to use isolated builds and not run into a circular dependency (since setuptools requires this project as a dependency for building wheels). As a bonus, we can consolidate all build and tooling configuration into
pyproject.toml
.