-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drop use of deprecated pkg_resources #508
drop use of deprecated pkg_resources #508
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #508 +/- ##
==========================================
+ Coverage 68.35% 68.67% +0.31%
==========================================
Files 12 12
Lines 929 964 +35
==========================================
+ Hits 635 662 +27
- Misses 294 302 +8
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
51fcf0b
to
0c6b17f
Compare
ah annoyingly this fails on python 3.7 due to the missing importlib.metadata and vendoring importlib_metadata is a bit of a pain as it needs zipp and typing_extensions there's only 3 months and 2 weeks left of python 3.7 support can it be dropped? |
2a63d10
to
7817210
Compare
actually I can do this with |
82b857b
to
69022f6
Compare
Are all of those |
Yeah I manually copied across the files imported by requirements.py https://github.com/pypa/wheel/pull/508/files#diff-3f63151da655b90d5d7ec0932887c5a073679a0917dfe94a9617a4e2806ae9caR8 and version.py https://github.com/pypa/wheel/pull/508/files#diff-4ca355345b43bff399508dc8133341267a5aa2bde8035345495d759d0df4c247R15 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Oh, one more thing: could you add a line to the changelog? I will merge then. |
@agronholm done |
Thanks! |
re: #507