Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop use of deprecated pkg_resources #508

Merged
merged 7 commits into from
Mar 11, 2023

Conversation

graingert
Copy link
Contributor

@graingert graingert commented Mar 10, 2023

re: #507

@codecov
Copy link

codecov bot commented Mar 10, 2023

Codecov Report

Patch coverage: 82.22% and project coverage change: +0.31 🎉

Comparison is base (fb33195) 68.35% compared to head (df143c4) 68.67%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #508      +/-   ##
==========================================
+ Coverage   68.35%   68.67%   +0.31%     
==========================================
  Files          12       12              
  Lines         929      964      +35     
==========================================
+ Hits          635      662      +27     
- Misses        294      302       +8     
Impacted Files Coverage Δ
src/wheel/bdist_wheel.py 51.90% <45.45%> (-0.94%) ⬇️
src/wheel/metadata.py 96.66% <94.11%> (-1.73%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@graingert graingert force-pushed the drop-pkg-resources-from-bdist-wheel branch from 51fcf0b to 0c6b17f Compare March 10, 2023 11:27
@graingert
Copy link
Contributor Author

graingert commented Mar 10, 2023

ah annoyingly this fails on python 3.7 due to the missing importlib.metadata and vendoring importlib_metadata is a bit of a pain as it needs zipp and typing_extensions

there's only 3 months and 2 weeks left of python 3.7 support can it be dropped?

@graingert graingert changed the title drop pkg_resources from bdist_wheel drop use of deprecated pkg_resources Mar 10, 2023
@graingert graingert force-pushed the drop-pkg-resources-from-bdist-wheel branch from 2a63d10 to 7817210 Compare March 10, 2023 12:25
@graingert
Copy link
Contributor Author

actually I can do this with setuptools.__version__ instead of importlib.metadata.distribution("setuptools").version because setuptools is already imported in bdist_wheel.py

@graingert graingert marked this pull request as ready for review March 10, 2023 12:26
@graingert graingert force-pushed the drop-pkg-resources-from-bdist-wheel branch from 82b857b to 69022f6 Compare March 10, 2023 12:53
@agronholm
Copy link
Contributor

Are all of those packaging modules needed?

@graingert
Copy link
Contributor Author

graingert commented Mar 10, 2023

Copy link
Contributor

@agronholm agronholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@agronholm
Copy link
Contributor

Oh, one more thing: could you add a line to the changelog? I will merge then.

@graingert
Copy link
Contributor Author

@agronholm done

docs/news.rst Outdated Show resolved Hide resolved
@agronholm agronholm merged commit f799533 into pypa:main Mar 11, 2023
@agronholm
Copy link
Contributor

Thanks!

@graingert graingert deleted the drop-pkg-resources-from-bdist-wheel branch March 11, 2023 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants