chore: some touchups & 3.12 classifier #539
Conversation
henryiii
force-pushed
the
henryiii/chore/312+
branch
2 times, most recently
from
5f14140 to
73c3689
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #539 +/- ##
=======================================
Coverage 70.20% 70.20%
=======================================
Files 13 13
Lines 1074 1074
=======================================
Hits 754 754
Misses 320 320
☔ View full report in Codecov by Sentry. |
| @@ -18,6 +18,7 @@ classifiers = [ | |||
| "Programming Language :: Python :: 3.9", | |||
| "Programming Language :: Python :: 3.10", | |||
| "Programming Language :: Python :: 3.11", | |||
| "Programming Language :: Python :: 3.12", | |||
There was a problem hiding this comment.
Since we are testing on the 3.12 betas, makes sense to add this after #529.
| @@ -98,26 +99,28 @@ select = [ | |||
| "I", # isort | |||
| "PGH", # pygrep-hooks | |||
| "UP", # pyupgrade | |||
| "B0", # flake8-bugbear | |||
| "B", # flake8-bugbear | |||
There was a problem hiding this comment.
I'm not sure partial codes like this this works in Ruff. It also is smarter about enabling B9* codes since it knows your min Python version supported.
| package = wheel | ||
| wheel_build_env = .pkg |
There was a problem hiding this comment.
This speeds up the testing by pre-building the wheel once for all Python versions (Tox 4 feature).
| depends = lint | ||
| commands = {envpython} -b -m pytest {posargs} | ||
| commands = {env_python} -b -m pytest {posargs} |
There was a problem hiding this comment.
Either work, guessing this is the newer, preferred spelling.
henryiii
force-pushed
the
henryiii/chore/312+
branch
from
73c3689 to
967ad3c
Compare
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
henryiii
force-pushed
the
henryiii/chore/312+
branch
from
967ad3c to
fd86380
Compare
|
Since #529 went in, this is ready, I think. |
|
Thanks. |
Some small changes that might be helpful. Comments will be inline.