-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecated bdist_wheel and updated the README #631
Conversation
@jaraco no objections from you I assume? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #631 +/- ##
==========================================
+ Coverage 71.03% 71.11% +0.07%
==========================================
Files 13 14 +1
Lines 1084 1087 +3
==========================================
+ Hits 770 773 +3
Misses 314 314 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good to me.
One thing to consider - users of a newer wheel
but older setuptools
will get the deprecation warning. That seems unlikely, given that those two packages are typically maintained at the same cadence. And since this version of wheel requires Python 3.8 (matching Setuptools), it won't leak into older Pythons that might require an older Setuptools.
No objections.
FYI, out of the box on PyPy3.8 and CPython 3.8-3.11, I'm seeing old setuptools and new wheel. Pretty sure it's happening because setuptools is pre-installed, but wheel is... not? I clearly see wheel being installed and no install of setuptools. And the failure will always show up if that's the case, because setuptools is just loading entry points when it triggers this. On PyPy 3.8, it's setuptools 58. (I don't mind fixing the broken jobs, but something to keep in mind, especially for when this deprecation cycle is over.)
|
Prevent accidental warning from deprecated entrypoint in `pypa/wheel#631`
…ols' The `bdist_wheel` module was moved from the "wheel" pkg to the "setuptools" package. This means we need either an old version of wheel or a new version of setuptools. fixes #3 ref pypa/wheel#631 ref pypa/setuptools#4369
For mortals, what is the fix for this deprecation error please? I have installed setuptools with pip. I don't know what wheel is or how to update it, so I am not sure how to get around this. Many thanks. Python 3.12.7 with pip 24.3.1 |
What version of setuptools do you have then? |
Thank you @agronholm. setuptools 75.8.0 |
Odd - that should be more than recent enough. Can you paste the console output? |
Console output...
|
All I am seeing is a compilation error, and not the deprecation warning from |
Apologies if I am asking about this in the wrong place. There is a section fairly early on, with the following content:
That took me here, thinking it was the main issue. This project was compiling a few months ago, and I'm using virtualenv so I'm surprised that it's now broken. Obviously long term I'll need to fix anything that's now deprecated, just can't see which package is (I assume) is too recent or out of date to make it break. |
Have you considered updating |
Actually, that won't help. The authors have not updated their packaging configuration: https://sourceforge.net/p/ruamel-yaml-clib/code/ci/default/tree/setup.py#l292 |
They also have |
🎉 I used pip-upgrade to upgrade If I encounter further errors I'll complain to ruamel as suggested. I really appreciate this help @agronholm as Python is not my 'first' language. :) If there's anything I can do for you please let me know. |
I went to complain to ruamel to help future people, and I saw they had updated wheels for Python 3.13 in version 0.2.12 https://sourceforge.net/p/ruamel-yaml-clib/tickets/36/, although I see the line of code you referenced in tag 0.2.12 so I am left slightly confused. I will let them know if I can find a way to describe the issue that remains. |
Install a binary wheel will simply bypass the issue, as you're not building a wheel locally. |
This is the next step towards completely eliminating any setuptools entanglements in
wheel
.