-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactored the wheel convert
command to not require setuptools
#640
Conversation
This also aims to improve the correctness of the egg and bdist_wininst conversions.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #640 +/- ##
==========================================
+ Coverage 71.18% 77.96% +6.78%
==========================================
Files 14 14
Lines 1093 1121 +28
==========================================
+ Hits 778 874 +96
+ Misses 315 247 -68 ☔ View full report in Codecov by Sentry. |
Gotta say, I spent way too much time on this feature that probably no one will use anymore... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don’t have a use for the command at the moment, but code looks reasonable.
Thanks for the review! |
This also aims to improve the correctness of the egg and bdist_wininst conversions.
Fixes #510.