Only configure setuptools logging if bdist_wheel is imported #641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also aims to improve the correctness of the egg and bdist_wininst conversions.
Also fix the output of `wheel convert` to add the final "OK" on the same line as the source file name. Fixes #632.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #641 +/- ##
==========================================
+ Coverage 77.96% 78.14% +0.17%
==========================================
Files 14 14
Lines 1121 1121
==========================================
+ Hits 874 876 +2
+ Misses 247 245 -2 ☔ View full report in Codecov by Sentry. |
henryiii
reviewed
Nov 8, 2024
| @@ -34,6 +34,15 @@ | |||
| if TYPE_CHECKING: | |||
| import types | |||
|
|
|||
| # ensure Python logging is configured | |||
| try: | |||
| __import__("setuptools.logging") | |||
There was a problem hiding this comment.
Suggested change
| __import__("setuptools.logging") | |
| import setuptools.logging |
Why not this? They should be the same, right? Usually you use this form if you have a variable value to import.
There was a problem hiding this comment.
(Though now I see this is just moved...)
henryiii
reviewed
Nov 8, 2024
| @@ -293,7 +293,7 @@ def convert(files: list[str], dest_dir: str, verbose: bool) -> None: | |||
| source = WininstFileSource(path) | |||
|
|
|||
| if verbose: | |||
| print(f"{archive}... ", flush=True) | |||
| print(f"{archive}...", flush=True, end="") | |||
There was a problem hiding this comment.
I don't think so...? There's no docs indicating either way, and wheel tags prints the file names to stdout.
henryiii
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents the CLI commands from emitting unwanted output.
Fixes #632.