Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

TVPaint frame range definition #1424

Merged
merged 24 commits into from
Apr 30, 2021

Conversation

iLLiCiTiT
Copy link
Member

@iLLiCiTiT iLLiCiTiT commented Apr 28, 2021

Changes

  • TVPaint implementation does not care about Mark In/Out values but only range
    • Frame index of Mark In is not modified so artist can set it to different frame than 1 but duration of Mark In/Out must match to duration of asset (shot) ({frame end} - {frame start} + 1) + {handle start} + {handle end}
  • Layers that does not have any content in Mark range are skipped during extractor
  • extractor extract range from Mark in/out but then rename file sequences to right names
    • e.g. if Mark In is 0 and frameStart is 1001 then output "frame.0000.png" is renamed to "frame.1001.png"
    • renaming is going backwards from Mark Out/Frame End to Mark In/Frame Start to avoid clashing of filenames
OpenPype 2 PRs
OpenPype #1425

@iLLiCiTiT iLLiCiTiT self-assigned this Apr 28, 2021
@iLLiCiTiT
Copy link
Member Author

iLLiCiTiT commented Apr 29, 2021

Found bug: Don't expect Handle start/end

@iLLiCiTiT
Copy link
Member Author

Found bug: Don't expect Handle start/end

Should be fixed now.

New changes

  • output frame range use handles (not only frame start/end)
  • as validation of mark in/out is optional added check of rendered range and output range and modify their values before rendering
    • if mark in/out range match output range it should have no affect
  • renaming of filenames happens in one method out of rendering methods

@64qam
Copy link
Member

64qam commented Apr 29, 2021

Looks good

@mkolar mkolar added this to the 2.17.1 milestone Apr 30, 2021
@mkolar mkolar added the type: enhancement Enhancements to existing functionality label Apr 30, 2021
@mkolar mkolar merged commit a42bdf7 into 2.x/develop Apr 30, 2021
@mkolar mkolar deleted the bugfix/tvpaint_frame_range_definition branch April 30, 2021 07:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: enhancement Enhancements to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants