Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

TVPaint frame range definition #1425

Merged
merged 10 commits into from
Apr 30, 2021

Conversation

iLLiCiTiT
Copy link
Member

@iLLiCiTiT iLLiCiTiT commented Apr 28, 2021

Changes

  • TVPaint implementation does not care about Mark In/Out values but only range
    • Frame index of Mark In is not modified so artist can set it to different frame than 1 but duration of Mark In/Out must match to duration of asset (shot) ({frame end} - {frame start} + 1) + {handle start} + {handle end}
  • Layers that does not have any content in Mark range are skipped during extractor
  • extractor extract range from Mark in/out but then rename file sequences to right names
    • e.g. if Mark In is 0 and frameStart is 1001 then output "frame.0000.png" is renamed to "frame.1001.png"
    • renaming is going backwards from Mark Out/Frame End to Mark In/Frame Start to avoid clashing of filenames
Pype 2 PRs
pype #1424

EDITED 29.4.2022:

New changes

  • as validation of mark in/out is optional extractor can handle that
    • if mark in/out range match output range it should have no affect
  • renaming of filenames happens in one method out of rendering methods

@64qam
Copy link
Member

64qam commented Apr 29, 2021

Looks good

@mkolar mkolar merged commit 7db10b5 into develop Apr 30, 2021
@mkolar mkolar deleted the bugfix/3.0_tvpaint_frame_range_definition branch April 30, 2021 07:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants