Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Ask user to restart after changing global environments in settings #1550

Merged
merged 26 commits into from
May 27, 2021
Merged

Ask user to restart after changing global environments in settings #1550

merged 26 commits into from
May 27, 2021

Conversation

create-issue-branch[bot]
Copy link

@create-issue-branch create-issue-branch bot commented May 20, 2021 •
edited by iLLiCiTiT
Loading

Description

  • tell user modifying settings that his changes require restart of openpype to take an effect

Changes

  • it is possible to mark entity in schemas that it's state change may require restart of openpype
    • this mark can't be added to dynamic items
    • if added to entity with children (dict) value is propagated to it's children if not set explicitly
    • only endpoint entities handle callbacks (e.g. dict don't handle changes because has children that should handle that)
  • root item have collection of entities that require restart and registered callbacks that are triggered if the value changes
  • label in settings ui tell user that his changes require to restart all OpenPype processes to take an effect
  • it is possible to restart tray (if settings are running in tray)
    • added dialog which asks user if it should be done
    • implemented restart_tray method in tray tool

TODO

  • don't check for entity state change but only value change (restart is not required if empty dictionary was added to studio overrides but kept empty)

closes #910

mkolar and others added 20 commits May 20, 2021 16:19
@mkolar
Create draft PR for #910
1921542
@iLLiCiTiT
entity knows if should openpype requires restart
bbb2e15
@iLLiCiTiT
added schema validation for specific values
a18aa04
@iLLiCiTiT
root entity can trigger callbacks if restart require entity changed i…
18b10d8 
…t's state
@iLLiCiTiT
endpoint entities can trigger changes on root item
e2ae219
@iLLiCiTiT
added require_restart on two entities in settings
4f6b99f
@iLLiCiTiT
category can show a label that changes require install
2e309f1
@iLLiCiTiT
added atexit callback to tray widget
faa32ad
@iLLiCiTiT
TrayManger has exit method
abaf323
@iLLiCiTiT
implemented restart method for tray tool
4fb40ac
@iLLiCiTiT
added restart_tray method to TrayModulesManager so models can call it
8013228
@iLLiCiTiT
save on categories can trigger restart_required_trigger signal if cha…
f1a2b79 
…nges require restart
@iLLiCiTiT
Settings window register slots for restart_required_trigger signal
d0bd67d
@iLLiCiTiT
created RestartDialog aasking if user want to restart current process
734e503
@iLLiCiTiT
Settings window has trigger_restart signal which meant to be triggere…
859ed68 
…d if saved changes require restart
@iLLiCiTiT
show restart dialog on restart require
38afc53
@iLLiCiTiT
dont show dialog if nothing is listening to trigger_restart signal
1be7266
@iLLiCiTiT
restart label is centered in footer
4bdcc8f
@iLLiCiTiT
reset label text on save
5c9d429
@iLLiCiTiT
settings module action can trigger restart of tray
6bc925f
@iLLiCiTiT iLLiCiTiT marked this pull request as ready for review May 27, 2021 11:05
@iLLiCiTiT iLLiCiTiT self-assigned this May 27, 2021
@iLLiCiTiT iLLiCiTiT requested a review from a team May 27, 2021 11:05
@iLLiCiTiT iLLiCiTiT added backend type: enhancement Enhancements to existing functionality labels May 27, 2021
@mkolar mkolar merged commit 194c81b into develop May 27, 2021
@mkolar mkolar deleted the feature/910-ask-user-to-restart-after-changing-global-environments-in-settings branch May 27, 2021 19:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mkolar mkolar mkolar approved these changes

Assignees

@iLLiCiTiT iLLiCiTiT

Labels
type: enhancement Enhancements to existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ask user to restart after changing global environments in settings
2 participants
@mkolar @iLLiCiTiT