Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Expose stop timer through rest api. #1886

Merged
merged 1 commit into from
Jul 30, 2021
Merged

Expose stop timer through rest api. #1886

merged 1 commit into from
Jul 30, 2021

Conversation

tokejepsen
Copy link
Member

This exposes the stop_timers method of the timers manager through the rest api.

Went with stop_timer instead of stop_timers to align with start_timer.

@tokejepsen tokejepsen requested review from mkolar and kalisp July 30, 2021 11:14
@tokejepsen tokejepsen self-assigned this Jul 30, 2021
@tokejepsen tokejepsen added the type: enhancement Enhancements to existing functionality label Jul 30, 2021
@tokejepsen tokejepsen mentioned this pull request Jul 30, 2021
Merged
iLLiCiTiT
iLLiCiTiT approved these changes Jul 30, 2021
View reviewed changes
Copy link
Member

@iLLiCiTiT iLLiCiTiT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@iLLiCiTiT iLLiCiTiT merged commit 64a80d4 into ynput:develop Jul 30, 2021
@tokejepsen tokejepsen deleted the feature/stop_timer_rest_api branch July 30, 2021 11:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@iLLiCiTiT iLLiCiTiT iLLiCiTiT approved these changes

@mkolar mkolar Awaiting requested review from mkolar

@kalisp kalisp Awaiting requested review from kalisp

Assignees

@tokejepsen tokejepsen

Labels
type: enhancement Enhancements to existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tokejepsen @iLLiCiTiT