Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

TVPaint: Option to stop timer on application exit. #1887

Conversation

tokejepsen
Copy link
Member

Stop the timer when exiting TVPaint.

Depends on #1886 and ynput/avalon-core#358

@tokejepsen tokejepsen added type: enhancement Enhancements to existing functionality host: TV Paint labels Jul 30, 2021
@tokejepsen tokejepsen self-assigned this Jul 30, 2021
Copy link
Member

@mkolar mkolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is quite dangerous to drop globally as it can easily turn off timers that the user would prefer to keep running. We'd be happy to merge this in, but it needs to be made optional in the studio settings, otherwise, it would affect production too much.

Making the feature optional.
@tokejepsen
Copy link
Member Author

Good point! Have updated so it respects a setting called Stop timer on application exit.

@tokejepsen
Copy link
Member Author

This is ready to go now.

@mkolar mkolar self-requested a review September 24, 2021 16:43
@mkolar mkolar changed the title TVPaint: Stop timer on application exit. TVPaint: Option to stop timer on application exit. Sep 24, 2021
@mkolar mkolar merged commit 092b2f3 into ynput:develop Oct 6, 2021
@tokejepsen tokejepsen deleted the feature/tvpaint_stop_timer_on_application_exit branch October 6, 2021 16:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
host: TV Paint type: enhancement Enhancements to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants