Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

FFmpeg: Split command to list does not work #2046

Merged
merged 5 commits into from
Sep 21, 2021

Conversation

iLLiCiTiT
Copy link
Member

@iLLiCiTiT iLLiCiTiT commented Sep 20, 2021

Issue

Changes

  • don't use split_command_to_list for unknown string commands
  • removed split_command_to_list
  • added shell=True where ffmpeg command is not list of arguments but string

NOTE

  • this is step back to previous state but now it should be more secure as we handle paths correctly

Related to #2045

@iLLiCiTiT iLLiCiTiT self-assigned this Sep 20, 2021
@iLLiCiTiT iLLiCiTiT added severity: HIGH type: bug Something isn't working labels Sep 20, 2021
@iLLiCiTiT iLLiCiTiT merged commit cfa6687 into develop Sep 21, 2021
@iLLiCiTiT iLLiCiTiT deleted the bugfix/ffmpeg_command_split branch December 13, 2021 15:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants