This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Some versions of python (on unix) may not be able to parse subprocess arguments so they can know which part is executable and which parts are arguments. This is mainly issue of ffmpeg arguments where in most of cases use string as full command.
Goal
Pass arguments to
subprocess.Popen
as list instead of string.Changes
split_command_to_list
which should be able return list of arguments created from passed subprocess commandpath_to_subprocess_arg
which decides if path should be wrapped in quotes in subprocess argumentssplit_command_to_list
which can't know if quotes are intended or notsplit_command_to_list
where subprocess arguments may not be known (where use settings values etc.)path_to_subprocess_arg
for all path arguments in subprocess commands wheresplit_command_to_list
is usedHow to test