Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

PYPE-1218 - changed namespace to contain subset name in Maya #2114

Merged
merged 2 commits into from
Oct 13, 2021

Conversation

kalisp
Copy link
Member

@kalisp kalisp commented Oct 7, 2021

Closes https://app.clickup.com/t/6658547/PYPE-1218
Closes #1339

(Testing use case: loaded from Hero asset 2x modelLOD1 subset, 1x modelMain)
Existing situation:

Screenshot 2021-10-07 130325

Newly implemented:
Screenshot 2021-10-07 124841

Not sure about names at the top of newly implemented (namespace contains subset + subset again)

Newly newly implemented:
Screenshot 2021-10-11 113454

@kalisp kalisp added host: Maya type: feature Larger, user affecting changes and completely new things labels Oct 7, 2021
@kalisp kalisp self-assigned this Oct 7, 2021
@mkolar
Copy link
Member

mkolar commented Oct 7, 2021

Task linked: PYPE-1218 Maya: Loaded reference names

@mkolar
Copy link
Member

mkolar commented Oct 8, 2021

Not sure about names at the top of newly implemented (namespace contains subset + subset again)

yeah it's not the prettiest. I reckon we could name that group just _GRP

The top node would then be quite consistent with the rest. Hero_modelMain_01:_GRP

Secondly I've no idea why we have that trailing _ the namespaces

@davidlatwe
Copy link
Contributor

Hmmm, does namespace also get's updated if the subset is being switched ?

@davidlatwe
Copy link
Contributor

davidlatwe commented Oct 8, 2021

Secondly I've no idea why we have that trailing _ the namespaces

I think it's to avoid Maya to increment last digit. e.g. using shot name as namespace

@mkolar
Copy link
Member

mkolar commented Oct 8, 2021

Hmmm, does namespace also get's updated if the subset is being switched?

You're right we're not changing the namespace at the moment and it certainly needs to happen.

I think it's to avoid Maya to increment last digit. e.g. using shot name as namespace

right. Isn't that irrelevant at this point though considering we're in control of those namespaces and they always actually have number to increment at the end.

@davidlatwe
Copy link
Contributor

Isn't that irrelevant at this point though considering we're in control of those namespaces

Ah, you're right, and my example case wasn't good.
I did see artist doing things like duplicating loaded stuff and Maya bumping the namespace ("foo_01_:" -> "foo_01_1"). But that's another topic though :P

@kalisp
Copy link
Member Author

kalisp commented Oct 11, 2021

Fixed a bit names of groups (see new attachment in description). AFAIK I am not able to get rid of trailing '_' in namespace without messing up with 'RN' nodes (which naming we don't have full control of).

Copy link
Member

@antirotor antirotor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me

@kalisp kalisp merged commit 049ea39 into develop Oct 13, 2021
@kalisp kalisp deleted the PYPE-1218_Maya-Loaded-reference-names branch October 13, 2021 15:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
host: Maya type: feature Larger, user affecting changes and completely new things
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maya: Loaded reference names
4 participants