Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Maya: Stop creation of reviews for Cryptomattes #2832

Merged
merged 2 commits into from
Mar 4, 2022

Conversation

antirotor
Copy link
Member

Quick fix

This is fixing an issue where cryptomattes were still used for generation review videos even if they shouldn't. This then caused crash with ffmpeg during publishing because it cannot handle data stored in exrs.


How to test

Publish render from Maya with cryptomattes enabled in any AOV.

🗒️ This is really just quick fix and proper solution is needed. Currently we are looking for crypto string in subset name but this is too broad definition.

@antirotor antirotor added the type: bug Something isn't working label Mar 2, 2022
@antirotor antirotor self-assigned this Mar 2, 2022
@BigRoy
Copy link
Collaborator

BigRoy commented Mar 2, 2022

Probably best to add a # todo in code too?

@iLLiCiTiT
Copy link
Member

Why it is crashing? Shouldn't this be fixed with https://github.com/pypeclub/OpenPype/pull/2635/files ?

@antirotor
Copy link
Member Author

antirotor commented Mar 2, 2022

Why it is crashing? Shouldn't this be fixed with https://github.com/pypeclub/OpenPype/pull/2635/files ?

ffmpeg is not handling CryptoMesh channel for some reason

2022-03-01 16:12:16:  0: STDOUT: [exr @ 000001cc04432440] Unsupported channel CryptoMesh.A.
2022-03-01 16:12:16:  0: STDOUT: [exr @ 000001cc04432440] Unsupported channel CryptoMesh.B.
2022-03-01 16:12:16:  0: STDOUT: [exr @ 000001cc04432440] Unsupported channel CryptoMesh.G.
2022-03-01 16:12:16:  0: STDOUT: [exr @ 000001cc04432440] Unsupported channel CryptoMesh.R.
2022-03-01 16:12:16:  0: STDOUT: [exr @ 000001cc04432440] Unsupported channel CryptoMesh00.A.
2022-03-01 16:12:16:  0: STDOUT: [exr @ 000001cc04432440] Unsupported channel CryptoMesh00.B.
2022-03-01 16:12:16:  0: STDOUT: [exr @ 000001cc04432440] Unsupported channel CryptoMesh00.G.
2022-03-01 16:12:16:  0: STDOUT: [exr @ 000001cc04432440] Unsupported channel CryptoMesh00.R.
2022-03-01 16:12:16:  0: STDOUT: [exr @ 000001cc04432440] Unsupported channel CryptoMesh01.A.
2022-03-01 16:12:16:  0: STDOUT: [exr @ 000001cc04432440] Unsupported channel CryptoMesh01.B.
2022-03-01 16:12:16:  0: STDOUT: [exr @ 000001cc04432440] Unsupported channel CryptoMesh01.G.
2022-03-01 16:12:16:  0: STDOUT: [exr @ 000001cc04432440] Unsupported channel CryptoMesh01.R.
2022-03-01 16:12:16:  0: STDOUT: [exr @ 000001cc04432440] Unsupported channel CryptoMesh02.A.
2022-03-01 16:12:16:  0: STDOUT: [exr @ 000001cc04432440] Unsupported channel CryptoMesh02.B.
2022-03-01 16:12:16:  0: STDOUT: [exr @ 000001cc04432440] Unsupported channel CryptoMesh02.G.
2022-03-01 16:12:16:  0: STDOUT: [exr @ 000001cc04432440] Unsupported channel CryptoMesh02.R.
2022-03-01 16:12:16:  0: STDOUT: [exr @ 000001cc04432440] Unsupported channel CryptoMesh03.A.
2022-03-01 16:12:16:  0: STDOUT: [exr @ 000001cc04432440] Unsupported channel CryptoMesh03.B.
2022-03-01 16:12:16:  0: STDOUT: [exr @ 000001cc04432440] Unsupported channel CryptoMesh03.G.
2022-03-01 16:12:16:  0: STDOUT: [exr @ 000001cc04432440] Unsupported channel CryptoMesh03.R.
2022-03-01 16:12:16:  0: STDOUT: [exr @ 000001cc04432440] Unsupported channel CryptoMesh04.A.
2022-03-01 16:12:16:  0: STDOUT: [exr @ 000001cc04432440] Unsupported channel CryptoMesh04.B.
2022-03-01 16:12:16:  0: STDOUT: [exr @ 000001cc04432440] Unsupported channel CryptoMesh04.G.
2022-03-01 16:12:16:  0: STDOUT: [exr @ 000001cc04432440] Unsupported channel CryptoMesh04.R.
2022-03-01 16:12:16:  0: STDOUT: [exr @ 000001cc04432440] Unsupported channel CryptoMesh05.A.
2022-03-01 16:12:16:  0: STDOUT: [exr @ 000001cc04432440] Unsupported channel CryptoMesh05.B.
2022-03-01 16:12:16:  0: STDOUT: [exr @ 000001cc04432440] Unsupported channel CryptoMesh05.G.
2022-03-01 16:12:16:  0: STDOUT: [exr @ 000001cc04432440] Unsupported channel CryptoMesh05.R.
2022-03-01 16:12:16:  0: STDOUT: [exr @ 000001cc04432440] Missing red channel.
2022-03-01 16:12:16:  0: STDOUT: [exr @ 000001cc04432440] Missing green channel.
2022-03-01 16:12:16:  0: STDOUT: [exr @ 000001cc04432440] Missing blue channel.
2022-03-01 16:12:16:  0: STDOUT: [exr_pipe @ 000001cc04430500] decoding for stream 0 failed
2022-03-01 16:12:16:  0: STDOUT: [exr_pipe @ 000001cc04430500] Could not find codec parameters for stream 0 (Video: exr, none): unspecified size
2022-03-01 16:12:16:  0: STDOUT: Consider increasing the value for the 'analyzeduration' (0) and 'probesize' (5000000) options

@iLLiCiTiT
Copy link
Member

ffmpeg is not handling CryptoMesh channel for some reason

So it is not converted using oiio or it is converted wrong. Because it does work in ExtractReview, or?

@mkolar
Copy link
Member

mkolar commented Mar 3, 2022

@antirotor
Copy link
Member Author

ffmpeg is not handling CryptoMesh channel for some reason

So it is not converted using oiio or it is converted wrong. Because it does work in ExtractReview, or?

This is in ExtractJpegEXR plugin, no oiio involved. I think this plugin should actually be reworked to use oiio rather then ffmpeg. Let ffmpeg handle video data and oiio sequences.

@antirotor antirotor merged commit 5de5a8b into develop Mar 4, 2022
@antirotor antirotor deleted the bugfix/review-skip-crypto branch March 4, 2022 14:30
@mkolar mkolar added this to the 3.9.0 milestone Mar 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants