This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
Maya: Stop creation of reviews for Cryptomattes #2832
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick fix
This is fixing an issue where cryptomattes were still used for generation review videos even if they shouldn't. This then caused crash with ffmpeg during publishing because it cannot handle data stored in exrs.
How to test
Publish render from Maya with cryptomattes enabled in any AOV.
🗒️ This is really just quick fix and proper solution is needed. Currently we are looking for
crypto
string in subset name but this is too broad definition.