Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

SiteSync: Providers ignore that site is disabled #3041

Merged

Conversation

kalisp
Copy link
Member

@kalisp kalisp commented Apr 8, 2022

Brief description

GDrive site was checking presence of credentials even if it was disabled on a project.

Description

This caused uncaught exceptions which prevented of synching of totally unrelated sites, which were configured correctly.
Same behavior noticed in Dropbox, SFTP checked also (without this issue).

Testing notes:

  1. Add Gdrive site in System Settings
  2. disable it on project settings
  3. restart Tray (without this fix, it would complain in the log that Gdrive credentials are missing)

@kalisp kalisp requested a review from m-u-r-p-h-y April 8, 2022 10:07
@kalisp kalisp self-assigned this Apr 8, 2022
@ynbot
Copy link
Contributor

ynbot commented Apr 8, 2022

Copy link
Member

@m-u-r-p-h-y m-u-r-p-h-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previously asking for gdrive credentials even though the site was not active in the project

  - { SyncServer }: [  Sync tasks count 0  ]
>>> [  Sync Server: No credentials for gdrive provider for 'gdrive' on path ''!  ]
  - { SyncServer }: [  Check representations for : murphy_test_hierarchy  ]

Not asking for gdrive credentails anymore

  - { SyncServer }: [  Sync Server: Site gdrive not enabled for murphy_test_hierarchy.  ]
  - { SyncServer }: [  Check representations for : murphy_test_hierarchy  ]

@kalisp kalisp merged commit 3754d48 into develop Apr 8, 2022
@kalisp kalisp deleted the bugfix/OP-3072_GDrive-provider-ignore-that-site-is-disabled branch April 8, 2022 11:13
@mkolar mkolar added this to the next milestone Apr 8, 2022
@mkolar mkolar added the type: bug Something isn't working label Apr 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants