Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

SiteSync: Providers ignore that site is disabled #3041

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 13 additions & 10 deletions openpype/modules/sync_server/providers/dropbox.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,19 @@ def __init__(self, project_name, site_name, tree=None, presets=None):
self.active = False
self.site_name = site_name
self.presets = presets
self.dbx = None

if not self.presets:
log.info(
"Sync Server: There are no presets for {}.".format(site_name)
)
return

if not self.presets["enabled"]:
log.debug("Sync Server: Site {} not enabled for {}.".
format(site_name, project_name))
return

token = self.presets.get("token", "")
if not token:
msg = "Sync Server: No access token for dropbox provider"
Expand All @@ -44,16 +50,13 @@ def __init__(self, project_name, site_name, tree=None, presets=None):
log.info(msg)
return

self.dbx = None

if self.presets["enabled"]:
try:
self.dbx = self._get_service(
token, acting_as_member, team_folder_name
)
except Exception as e:
log.info("Could not establish dropbox object: {}".format(e))
return
try:
self.dbx = self._get_service(
token, acting_as_member, team_folder_name
)
except Exception as e:
log.info("Could not establish dropbox object: {}".format(e))
return

super(AbstractProvider, self).__init__()

Expand Down
12 changes: 8 additions & 4 deletions openpype/modules/sync_server/providers/gdrive.py
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,11 @@ def __init__(self, project_name, site_name, tree=None, presets=None):
format(site_name))
return

if not self.presets["enabled"]:
log.debug("Sync Server: Site {} not enabled for {}.".
format(site_name, project_name))
return

current_platform = platform.system().lower()
cred_path = self.presets.get("credentials_url", {}). \
get(current_platform) or ''
Expand All @@ -97,11 +102,10 @@ def __init__(self, project_name, site_name, tree=None, presets=None):
return

self.service = None
if self.presets["enabled"]:
self.service = self._get_gd_service(cred_path)
self.service = self._get_gd_service(cred_path)

self._tree = tree
self.active = True
self._tree = tree
self.active = True

def is_active(self):
"""
Expand Down