Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Nuke: fixing farm publishing if review is disabled #3306

Merged
merged 8 commits into from
Jun 15, 2022
Merged

Nuke: fixing farm publishing if review is disabled #3306

merged 8 commits into from
Jun 15, 2022

Conversation

jakubjezek001
Copy link
Member

@jakubjezek001 jakubjezek001 commented Jun 8, 2022 •
edited by kalisp
Loading

Brief description

Nuke is now publishing on farm without review

Dependency

this PR also includes #3303

@jakubjezek001
Nuke: no need to add Nuke host to filter
10bf3a3 
It is actually  adding review even not needed
@jakubjezek001
Merge remote-tracking branch 'pypeclub/bugfix/changed_default_targets…
bcc1512 
…' into bugfix/OP-3362_Nuke-Farm-Publish-WITHOUT-Review-not-working
@jakubjezek001
Deadline: adding condition for review instance data key
248e38b 
to be able to pass review to metadata json from nuke
@jakubjezek001
Nuke: wrong name in docstring
6758bcc
@jakubjezek001 jakubjezek001 self-assigned this Jun 8, 2022
@ynbot
Copy link
Contributor

ynbot commented Jun 8, 2022

Task linked: OP-3362 Nuke Farm Publish WITHOUT Review not working

@jakubjezek001 jakubjezek001 added the type: bug Something isn't working label Jun 8, 2022
64qam
64qam suggested changes Jun 9, 2022
View reviewed changes
Copy link
Member

@64qam 64qam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't create an Ftrack review (e.g. mp4), but it still makes an empty link on Ftrack.
image

@64qam 64qam requested a review from iLLiCiTiT June 14, 2022 08:37
@iLLiCiTiT
Copy link
Member

There is missing "representations" key on instances if they go to farm which cause crashes. Would be possible to add the key in https://github.com/pypeclub/OpenPype/blob/develop/openpype/hosts/nuke/plugins/publish/precollect_instances.py#L139 for each instance?

@iLLiCiTiT
Copy link
Member

Also can we remove adding "instances" key to context here:
https://github.com/pypeclub/OpenPype/blob/develop/openpype/hosts/nuke/plugins/publish/precollect_instances.py#L161
https://github.com/pypeclub/OpenPype/blob/develop/openpype/hosts/nuke/plugins/publish/precollect_workfile.py#L104

It's not used anywhere...

@jakubjezek001 jakubjezek001 requested a review from 64qam June 14, 2022 09:14
64qam
64qam suggested changes Jun 14, 2022
View reviewed changes
Copy link
Member

@64qam 64qam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When review is disabled, it still creates a new empty Ftrack version, but with exr component in it.
image

@jakubjezek001 jakubjezek001 requested a review from 64qam June 15, 2022 11:40
@jakubjezek001 jakubjezek001 merged commit a0a7960 into develop Jun 15, 2022
@jakubjezek001 jakubjezek001 deleted the bugfix/OP-3362_Nuke-Farm-Publish-WITHOUT-Review-not-working branch June 15, 2022 14:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@64qam 64qam 64qam approved these changes

@kalisp kalisp Awaiting requested review from kalisp

@iLLiCiTiT iLLiCiTiT Awaiting requested review from iLLiCiTiT

Assignees

@jakubjezek001 jakubjezek001

Labels
type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jakubjezek001 @ynbot @iLLiCiTiT @64qam