Fix - added local targets to install host #3303
Conversation
By default when host is started, it should register targets to 'local', only if specific env var is set (OPENPYPE_REMOTE_PUBLISH) it should be 'remote'. This means farm is using host to collect/validate/extract and publish on behalf of artist.
install_host registers targets implicitly for all hosts
| @@ -115,7 +115,7 @@ def process(self, instance): | |||
| environment["OPENPYPE_REMOTE_JOB"] = "1" | |||
| environment["OPENPYPE_USERNAME"] = instance.context.data["user"] | |||
| environment["OPENPYPE_PUBLISH_SUBSET"] = instance.data["subset"] | |||
| environment["HEADLESS_PUBLISH"] = "1" | |||
There was a problem hiding this comment.
I'm seeing more usage across the code base of HEADLESS_PUBLISH as a value. Will changing this influence any of those unwantedly?
E.g. Collect Scene Version will trigger for the maya render too but will now NOT capture this value. Other than that it just seemed to appear in code intended for Photoshop and After Effects.
There was a problem hiding this comment.
I used same env var for two different use cases incorrectly. In this PR I renamed it more explicitly.
HEADLESS_PUBLISH is used in PS and AE mostly for automatic testing (where both apps are opened, pyblish run directly in those). PS uses same approach for Webpublisher, eg. external users could upload .psd which will be collected/extracted/published on their behalf. In this use case artist is not providing version in a .psd file name, but it is taken from DB (that is configurable by skip_hosts_headless_publish). I don't think it got triggered for Maya.
We plan to rename HEADLESS_PUBLISH to AUTOMATIC_PUBLISH in separate PR to make it more understandable, as it is not "headless" per se. Part of that PR will be more description in Dev documentation.
Brief description
By default when host is started, it should register targets to 'local', only if specific env var is set (OPENPYPE_REMOTE_PUBLISH) it should be 'remote'. This means
farm is using host to collect/validate/extract and publish on behalf of artist.
Description
Without this extractors weren't triggered in other host than Maya (which is explicitly setting targets to local because of implementation of remote pointcache publishing).
This PR sets 'targetst = ["local"]' to any host not started on a farm.
Testing notes: