This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
Nuke | Global: adding custom tags representation filtering #4009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also implement custom tags to exctractor
|
Task linked: OP-4217 ProRes4444 ACEScct mov profile |
jakubjezek001
added
host: Nuke
type: enhancement
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
Traceback (most recent call last):
Traceback (most recent call last):
File "/usr/local/bin/flake8", line 8, in
sys.exit(main())
File "/usr/local/lib/python3.8/dist-packages/flake8/main/cli.py", line 18, in main
app.run(argv)
File "/usr/local/lib/python3.8/dist-packages/flake8/main/application.py", line 393, in run
self._run(argv)
File "/usr/local/lib/python3.8/dist-packages/flake8/main/application.py", line 381, in _run
self.run_checks()
File "/usr/local/lib/python3.8/dist-packages/flake8/main/application.py", line 300, in run_checks
self.file_checker_manager.run()
File "/usr/local/lib/python3.8/dist-packages/flake8/checker.py", line 331, in run
self.run_serial()
File "/usr/local/lib/python3.8/dist-packages/flake8/checker.py", line 315, in run_serial
checker.run_checks()
File "/usr/local/lib/python3.8/dist-packages/flake8/checker.py", line 598, in run_checks
self.run_ast_checks()
File "/usr/local/lib/python3.8/dist-packages/flake8/checker.py", line 502, in run_ast_checks
for (line_number, offset, text, check) in runner:
File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 56, in run
parser.visit(self.tree)
File "/usr/lib/python3.8/ast.py", line 371, in visit
return visitor(node)
File "/usr/lib/python3.8/ast.py", line 379, in generic_visit
self.visit(item)
File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 39, in visit_ClassDef
self.capture_issues_visitor('ClassDef', node)
File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 33, in capture_issues_visitor
self.generic_visit(node)
File "/usr/lib/python3.8/ast.py", line 381, in generic_visit
self.visit(value)
File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 36, in visit_Call
self.capture_issues_visitor('Call', node)
File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 30, in capture_issues_visitor
issues = checker.run(node)
File "/usr/local/lib/python3.8/dist-packages/flake8_django/checkers/render.py", line 22, in run
if isinstance(arg, ast.Call) and arg.func.id == 'locals':
AttributeError: 'Attribute' object has no attribute 'id'
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
Traceback (most recent call last):
Traceback (most recent call last):
File "/usr/local/bin/flake8", line 8, in
sys.exit(main())
File "/usr/local/lib/python3.8/dist-packages/flake8/main/cli.py", line 18, in main
app.run(argv)
File "/usr/local/lib/python3.8/dist-packages/flake8/main/application.py", line 393, in run
self._run(argv)
File "/usr/local/lib/python3.8/dist-packages/flake8/main/application.py", line 381, in _run
self.run_checks()
File "/usr/local/lib/python3.8/dist-packages/flake8/main/application.py", line 300, in run_checks
self.file_checker_manager.run()
File "/usr/local/lib/python3.8/dist-packages/flake8/checker.py", line 331, in run
self.run_serial()
File "/usr/local/lib/python3.8/dist-packages/flake8/checker.py", line 315, in run_serial
checker.run_checks()
File "/usr/local/lib/python3.8/dist-packages/flake8/checker.py", line 598, in run_checks
self.run_ast_checks()
File "/usr/local/lib/python3.8/dist-packages/flake8/checker.py", line 502, in run_ast_checks
for (line_number, offset, text, check) in runner:
File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 56, in run
parser.visit(self.tree)
File "/usr/lib/python3.8/ast.py", line 371, in visit
return visitor(node)
File "/usr/lib/python3.8/ast.py", line 379, in generic_visit
self.visit(item)
File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 39, in visit_ClassDef
self.capture_issues_visitor('ClassDef', node)
File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 33, in capture_issues_visitor
self.generic_visit(node)
File "/usr/lib/python3.8/ast.py", line 381, in generic_visit
self.visit(value)
File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 36, in visit_Call
self.capture_issues_visitor('Call', node)
File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 30, in capture_issues_visitor
issues = checker.run(node)
File "/usr/local/lib/python3.8/dist-packages/flake8_django/checkers/render.py", line 22, in run
if isinstance(arg, ast.Call) and arg.func.id == 'locals':
AttributeError: 'Attribute' object has no attribute 'id'
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
Traceback (most recent call last):
Traceback (most recent call last):
File "/usr/local/bin/flake8", line 8, in
sys.exit(main())
File "/usr/local/lib/python3.8/dist-packages/flake8/main/cli.py", line 18, in main
app.run(argv)
File "/usr/local/lib/python3.8/dist-packages/flake8/main/application.py", line 393, in run
self._run(argv)
File "/usr/local/lib/python3.8/dist-packages/flake8/main/application.py", line 381, in _run
self.run_checks()
File "/usr/local/lib/python3.8/dist-packages/flake8/main/application.py", line 300, in run_checks
self.file_checker_manager.run()
File "/usr/local/lib/python3.8/dist-packages/flake8/checker.py", line 331, in run
self.run_serial()
File "/usr/local/lib/python3.8/dist-packages/flake8/checker.py", line 315, in run_serial
checker.run_checks()
File "/usr/local/lib/python3.8/dist-packages/flake8/checker.py", line 598, in run_checks
self.run_ast_checks()
File "/usr/local/lib/python3.8/dist-packages/flake8/checker.py", line 502, in run_ast_checks
for (line_number, offset, text, check) in runner:
File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 56, in run
parser.visit(self.tree)
File "/usr/lib/python3.8/ast.py", line 371, in visit
return visitor(node)
File "/usr/lib/python3.8/ast.py", line 379, in generic_visit
self.visit(item)
File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 39, in visit_ClassDef
self.capture_issues_visitor('ClassDef', node)
File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 33, in capture_issues_visitor
self.generic_visit(node)
File "/usr/lib/python3.8/ast.py", line 381, in generic_visit
self.visit(value)
File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 36, in visit_Call
self.capture_issues_visitor('Call', node)
File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 30, in capture_issues_visitor
issues = checker.run(node)
File "/usr/local/lib/python3.8/dist-packages/flake8_django/checkers/render.py", line 22, in run
if isinstance(arg, ast.Call) and arg.func.id == 'locals':
AttributeError: 'Attribute' object has no attribute 'id'
iLLiCiTiT
reviewed
Oct 21, 2022
iLLiCiTiT
reviewed
Oct 21, 2022
Comment on lines
+1749
to
+1765
| # lower all filter tags | ||
| tag_filters_low = [tag.lower() for tag in tag_filters] | ||
|
|
||
| self.log.debug("__ tag_filters: {}".format(tag_filters)) | ||
| self.log.debug("__ repre_c_tags_low: {}".format( | ||
| repre_c_tags_low)) | ||
|
|
||
| # check if any repre tag is not in filter tags | ||
| for tag in repre_c_tags_low: | ||
| if tag in tag_filters_low: | ||
| valid = True | ||
| break | ||
|
|
||
| if not valid: | ||
| continue | ||
|
|
||
| filtered_outputs.append(output_def) |
There was a problem hiding this comment.
Removed unnecessary loggers and do tags filtering only if they are set.
Suggested change
| # lower all filter tags | |
| tag_filters_low = [tag.lower() for tag in tag_filters] | |
| self.log.debug("__ tag_filters: {}".format(tag_filters)) | |
| self.log.debug("__ repre_c_tags_low: {}".format( | |
| repre_c_tags_low)) | |
| # check if any repre tag is not in filter tags | |
| for tag in repre_c_tags_low: | |
| if tag in tag_filters_low: | |
| valid = True | |
| break | |
| if not valid: | |
| continue | |
| filtered_outputs.append(output_def) | |
| else: | |
| # lower all filter tags | |
| tag_filters_low = [tag.lower() for tag in tag_filters] | |
| # check if any repre tag is not in filter tags | |
| for tag in repre_c_tags_low: | |
| if tag in tag_filters_low: | |
| valid = True | |
| break | |
| if valid: | |
| filtered_outputs.append(output_def) |
There was a problem hiding this comment.
This will fix this issue too #4009 (review) Not true.
This change won't cause issues with old settings overrides.
jrsndl
suggested changes
Oct 21, 2022
64qam
approved these changes
Oct 21, 2022
jrsndl
approved these changes
Oct 21, 2022
jakubjezek001
deleted the
feature/OP-4217_ProRes4444-ACEScct-mov-profile
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief description
Representation can be filtered by custom tagging in extract review
Description
Extract review was filtering only on the publishing instance level and not able to aim directly at particular representation. We have to implement filtering method to be able to activate output preset only to particular representation.
Additional info
custom_tagas optional key to representationcustom_tagsto nuke extract review data movie pluginproject_settings/nuke/publish/ExtractReviewDataMov/outputs/baking/viewer_process_overridein case you want to add bake stream overide ofproject_settings/nuke/imageio/baking/viewerProcess(notice we hade moved imagio from Anatomy settings to project settings)viewer_name (display_name)ordisplay_name/viewer_namesRGB (ACES)orACES/sRGBMatching mechanics:
Testing notes:
project_settings/nuke/publish/ExtractReviewDataMov/outputsproject_settings/global/publish/ExtractReview/profilesnukeh264firstandh264firsttwo the same profiles, except one of them is having set Additional filtering tocustom tagswith the same input from step 3.