This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
General: Extract review does not crash with old settings overrides #4023
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief description
Avoid crashes in extract review with older settings overrides.
Description
This PR caused that extract review would crash with older settings overrides where
custom_tags
key is not available on output definitions so iteration overNone
is invalid operation. The tags validation also happened in all cases even if the valid state was already known. Removed unnecessary log messages.Testing notes: