-
Notifications
You must be signed in to change notification settings - Fork 129
Maya: keep existing AOVs when creating render instance #4087
Maya: keep existing AOVs when creating render instance #4087
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with M2023 and Arnold 5.2.0.1
working perfectly as expected.
I would have some UI and useability questions though
-
I would recommend changing the label to a more descriptive
Remove existing AOVs
-
This option should be available for all renderers (it is not Arnold specific)
should the button be placed in each renderer section or in the common, upper level?
In case we decide to keep the option per renderer we should just swap the order and keep all AOV related options together
@antirotor @mkolar what do you think?
I don't think it should be per renderer - and I agree with changing it to |
I have renamed in the updated PR as well as swapping the position of |
so for now is it only valid for Arnold? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested in maya2022
and maya2023
with Arnold 5.1.33
All working as expected! No issues found...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is some issue with vray
# Error: KeyError: file D:\REPO\OpenPype\openpype\hosts\maya\api\lib_rendersettings.py line 179: 'remove_aovs'
and with redshift nothing is happening when running Set Render Settings or creating a Render Instance
The updated PR has fixed the error of removing aovs as well as removing the light-select aov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is no error popping up with vray, but it is not fully working
only image prefix and output image format is set when creating the render instance and no other options are applied (no aovs, no engine, etc.)
the same issue is with Redshift
Did run new tests in maya with Regarding OP settings for AOVs (creation / deleting existing ones) All works fine in all three renderers. Succesfuly adds predefined AOVs in OP settings and also reacts to "Remove Existing AOVs" switch too... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Warning
Merging this needs updating v4 settings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Redshift 3.5.12
Maya 2022.4
AOVs work as expected
Brief description
Introduce an option to allow users to choose if existing AOVs should be kept when creating render instance in Openpype setting.
The setting is se to false by default
Description
The new options in Openpype Setting named "remove_AOVs" is avaliable in this PR. If this is set to be True, it would clean up the previous AOVs which is left by the deleted render instance. If this is set to be False, It would still store the existing AOVs as renderpasses.
Additional info
Nothing specific
Testing notes:
resolves #4073