Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Less mongo connections #509

Merged
merged 2 commits into from
Sep 8, 2020
Merged

Conversation

iLLiCiTiT
Copy link
Member

@iLLiCiTiT iLLiCiTiT commented Sep 8, 2020

New PR to release. Moved from PR #505.

Changes

  • most changes described in avalon-core's PR where AvalonMongoConnection and AvalonMongoDB are implemented
  • this gives possibility to create multiple objects holding differebt avalon contexts but won't create more connections to mongo

Description

  • All avalon connections are reduced to one per process, because singleton mongo db connection is created in a way that can handle multiple contexts
  • This does not mean much reduction in global space, since we use mongo also for logging (which is different connection), ftrack event server use it for storing events, users' ftrack action server is running in subprocess (have to create new connection). Same connections may be created also in hosts. With this PR is just reduced small part of an issue and got rid of io_nonsingleton at the same time.
This depends on
avalon-core ynput/avalon-core#187
pype-setup ynput/pype-setup#69

@iLLiCiTiT iLLiCiTiT changed the title Feature/less mongo connections Less mongo connections Sep 8, 2020
@iLLiCiTiT iLLiCiTiT self-assigned this Sep 8, 2020
@iLLiCiTiT iLLiCiTiT requested a review from a team September 8, 2020 13:34
@mkolar mkolar added this to the 2.12 milestone Sep 8, 2020
@mkolar mkolar merged commit 48c0243 into release/2.12.0-rc Sep 8, 2020
@mkolar mkolar added the type: enhancement Enhancements to existing functionality label Sep 9, 2020
@mkolar mkolar deleted the feature/less_mongo_connections branch September 9, 2020 16:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: enhancement Enhancements to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants