Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Less mongo connections #505

Closed
wants to merge 4 commits into from
Closed

Conversation

iLLiCiTiT
Copy link
Member

Changes

  • most changes described in avalon-core's PR where AvalonMongoConnection and AvalonMongoDB are implemented
  • this gives possibility to create multiple objects holding differebt avalon contexts but won't create more connections to mongo

Description

  • All avalon connections are reduced to one per process, because singleton mongo db connection is created in a way that can handle multiple contexts
  • This does not mean much reduction in global space, since we use mongo also for logging (which is different connection), ftrack event server use it for storing events, users' ftrack action server is running in subprocess (have to create new connection). Same connections may be created also in hosts. With this PR is just reduced small part of an issue and got rid of io_nonsingleton at the same time.
🏴 this depends on ynput/avalon-core#186

@iLLiCiTiT iLLiCiTiT marked this pull request as draft September 3, 2020 15:31
@iLLiCiTiT iLLiCiTiT self-assigned this Sep 3, 2020
@iLLiCiTiT iLLiCiTiT requested a review from a team September 3, 2020 15:31
@iLLiCiTiT iLLiCiTiT mentioned this pull request Sep 8, 2020
@iLLiCiTiT
Copy link
Member Author

PR moved to #509

@iLLiCiTiT iLLiCiTiT closed this Sep 8, 2020
@mkolar mkolar deleted the draft/less_mongo_connections branch September 9, 2020 16:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant