Accept language #109
Merged
Accept language #109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support for using the Accept-Language header to Fastly config for the currently known locales. Unfortunately needs to be edited every time locales change.
... to make intentions clearer.
di
reviewed
Oct 26, 2022
|
The one outstanding issue I see is that we currently have is that Babel uses CLDR language tags and Accept-Language uses IANA language tags... which use different casing and locale differentiators ( So I think our |
|
@di here is a Fastly Fiddle that shows how things work: https://fiddle.fastly.dev/fiddle/3506e1d7#req-8aa50147 |
di
approved these changes
Oct 26, 2022
|
@webknjaz this is now live on https://test.pypi.org for validation. I'm going to be poking at it to make sure all is well for a bit before making live on pypi.org |
ewdurbin
added a commit
to pypi/warehouse
that referenced
this pull request
Oct 26, 2022
With support for Accept-Language header from pypi/infra#109 we need to add a step so our VCL knows about the new locale.
di
pushed a commit
to pypi/warehouse
that referenced
this pull request
Oct 26, 2022
With support for Accept-Language header from pypi/infra#109 we need to add a step so our VCL knows about the new locale.
|
Active now for https://pypi.org |
This was referenced Oct 26, 2022
|
Sorry, I forgot to report back. This seems to work correctly on the HTTP level, per my testing: $ curl -ssvH 'Accept-Language: uk,en' https://pypi.org 2>&1 | head -c 5500 | grep -i lang
* h2h3 [accept-language: uk,en]
> accept-language: uk,en
<html lang="uk" dir="ltr">
<meta name="defaultLanguage" content="en">
<meta name="availableLanguages" content="en, es, fr, ja, pt_BR, uk, el, de, zh_Hans, zh_Hant, ru, he, eo">
$ curl -ssvH 'Accept-Language: en,uk,en' https://pypi.org 2>&1 | head -c 5500 | grep -i lang
* h2h3 [accept-language: en,uk,en]
> accept-language: en,uk,en
<html lang="en" dir="ltr">
<meta name="defaultLanguage" content="en">
<meta name="availableLanguages" content="en, es, fr, ja, pt_BR, uk, el, de, zh_Hans, zh_Hant, ru, he, eo">
<meta name="description" content="The Python Package Index (PyPI) is a repository of software for the Python programming language.">
$ curl -ssvH 'Accept-Language: weird,en,uk,en' https://pypi.org 2>&1 | head -c 5500 | grep -i lang
* h2h3 [accept-language: weird,en,uk,en]
> accept-language: weird,en,uk,en
<html lang="en" dir="ltr">
<meta name="defaultLanguage" content="en">
<meta name="availableLanguages" content="en, es, fr, ja, pt_BR, uk, el, de, zh_Hans, zh_Hant, ru, he, eo">
<meta name="description" content="The Python Package Index (PyPI) is a repository of software for the Python programming language.">
$ curl -ssvH 'Accept-Language: weird,uk,en' https://pypi.org 2>&1 | head -c 5500 | grep -i lang
* h2h3 [accept-language: weird,uk,en]
> accept-language: weird,uk,en
<html lang="uk" dir="ltr">
<meta name="defaultLanguage" content="en">
<meta name="availableLanguages" content="en, es, fr, ja, pt_BR, uk, el, de, zh_Hans, zh_Hant, ru, he, eo">
$ curl -ssvH 'Accept-Language: weird,BR,uk-UA,en' https://pypi.org 2>&1 | head -c 5500 | grep -i lang
* h2h3 [accept-language: weird,BR,uk-UA,en]
> accept-language: weird,BR,uk-UA,en
<html lang="uk" dir="ltr">
<meta name="defaultLanguage" content="en">
<meta name="availableLanguages" content="en, es, fr, ja, pt_BR, uk, el, de, zh_Hans, zh_Hant, ru, he, eo">
$ curl -ssvH 'Accept-Language: weird,pt-BR,uk-UA,en' https://pypi.org 2>&1 | head -c 5500 | grep -i lang
* h2h3 [accept-language: weird,pt-BR,uk-UA,en]
> accept-language: weird,pt-BR,uk-UA,en
<html lang="pt_BR" dir="ltr">
<meta name="defaultLanguage" content="en">
<meta name="availableLanguages" content="en, es, fr, ja, pt_BR, uk, el, de, zh_Hans, zh_Hant, ru, he, eo">
$ curl -ssvH 'Accept-Language: weird,pt,pt-BR,uk-UA,en' https://pypi.org 2>&1 | head -c 5500 | grep -i lang
* h2h3 [accept-language: weird,pt,pt-BR,uk-UA,en]
> accept-language: weird,pt,pt-BR,uk-UA,en
<html lang="pt_BR" dir="ltr">
<meta name="defaultLanguage" content="en">
<meta name="availableLanguages" content="en, es, fr, ja, pt_BR, uk, el, de, zh_Hans, zh_Hant, ru, he, eo">
# rtl test:
$ curl -ssvH 'Accept-Language: weird,he,pt,pt-BR,uk-UA,en' https://pypi.org 2>&1 | head -c 5500 | grep -i lang
* h2h3 [accept-language: weird,he,pt,pt-BR,uk-UA,en]
> accept-language: weird,he,pt,pt-BR,uk-UA,en
<html lang="he" dir="rtl">
<meta name="defaultLanguage" content="en">
<meta name="availableLanguages" content="en, es, fr, ja, pt_BR, uk, el, de, zh_Hans, zh_Hant, ru, he, eo"> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
superseedes #53