Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rate limiting to the XMLRPC Api #4321

Closed
dstufft opened this issue Jul 19, 2018 · 4 comments
Closed

Add rate limiting to the XMLRPC Api #4321

dstufft opened this issue Jul 19, 2018 · 4 comments

Comments

@dstufft
Copy link
Member

dstufft commented Jul 19, 2018

Currently whenever we get a big burst of XMLRPC requests, our service can start timing out and raising 5xx errors. We should introduce rate limiting in the XMLRPC API in order to force clients to slow their roll and not hammer us too hard.

@di
Copy link
Member

di commented Oct 21, 2020

Added in #4553.

@di di closed this as completed Oct 21, 2020
@pradyunsg
Copy link
Contributor

pradyunsg commented Oct 25, 2020

@di
Copy link
Member

di commented Oct 25, 2020

@pradyunsg We recently reduced the limit because the API was being abused and exhausting PyPI's backend resources.

The current limit is 2 per second / 30 per minute, so depending on how pip uses the XML-RPC APIs, you could add a delay to the affected tests.

@pradyunsg
Copy link
Contributor

Coolieo. pypa/pip#9051 should make it possible to work around those.

FWIW, I'm a +1 on giving a farewell to the search endpoint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants