-
Notifications
You must be signed in to change notification settings - Fork 980
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xmlrpc ratelimiting #4553
Merged
Merged
xmlrpc ratelimiting #4553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ewdurbin
force-pushed
the
xmlrpc_ratelimiting
branch
from
August 14, 2018 02:10
ffcfddf
to
4165ad8
Compare
dstufft
reviewed
Aug 14, 2018
dstufft
approved these changes
Aug 14, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One issue with the resets_in
usage, but otherwise LGTM.
ewdurbin
force-pushed
the
xmlrpc_ratelimiting
branch
2 times, most recently
from
August 20, 2018 19:13
004aa74
to
b0da5ff
Compare
ewdurbin
force-pushed
the
xmlrpc_ratelimiting
branch
from
August 26, 2020 14:33
8d2032c
to
927f453
Compare
ewdurbin
force-pushed
the
xmlrpc_ratelimiting
branch
from
August 26, 2020 21:27
5bd0315
to
93e9ef3
Compare
/me yawns... what was I doing? |
di
approved these changes
Aug 26, 2020
Can the actual limits be documented somewhere? |
Except that the limit has changed to 1 second, still he same issue.... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rate limit the xmlrpc endpoint per IP