Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xmlrpc ratelimiting #4553

Merged
merged 3 commits into from
Aug 26, 2020
Merged

xmlrpc ratelimiting #4553

merged 3 commits into from
Aug 26, 2020

Conversation

ewdurbin
Copy link
Member

@ewdurbin ewdurbin commented Aug 14, 2018

rate limit the xmlrpc endpoint per IP

Copy link
Member

@dstufft dstufft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One issue with the resets_in usage, but otherwise LGTM.

@ewdurbin ewdurbin force-pushed the xmlrpc_ratelimiting branch 2 times, most recently from 004aa74 to b0da5ff Compare August 20, 2018 19:13
@di di marked this pull request as draft July 1, 2020 03:06
@ewdurbin ewdurbin changed the title WIP: xmlrpc ratelimiting xmlrpc ratelimiting Aug 26, 2020
@ewdurbin
Copy link
Member Author

/me yawns... what was I doing?

@ewdurbin ewdurbin marked this pull request as ready for review August 26, 2020 22:02
@ewdurbin ewdurbin requested review from di and dstufft August 26, 2020 22:02
warehouse/legacy/api/xmlrpc/views.py Show resolved Hide resolved
@ewdurbin ewdurbin merged commit 80a95c2 into master Aug 26, 2020
@ewdurbin ewdurbin deleted the xmlrpc_ratelimiting branch August 26, 2020 22:18
@pfmoore
Copy link
Contributor

pfmoore commented Oct 25, 2020

Can the actual limits be documented somewhere?

@coogor
Copy link

coogor commented Nov 4, 2020

Except that the limit has changed to 1 second, still he same issue....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants