Run everything in containers

[xni]

$ make reformat

Create our Python 3.6 virtual environment

rm -rf .state/env
python3.6 -m venv .state/env
make: python3.6: No such file or directory
make: *** [.state/env/pyvenv.cfg] Error 1

[di]

At the moment you'll need Python 3.6 installed on your machine to run this command. I'd recommend using pyenv to have multiple Python versions installed.

If you're interested, we might want to look into a way to move this into a Docker container instead, to avoid this issue in the future.

[xni]

Yes, it would be great! Same for linting...

[shevelevs]

@di, I can work on this - should be pretty straightforward

[shevelevs]

I guess the question is whether you should be able to run stuff (especially build docs) without having to run docker. If that's the case, it makes sense to still preserve venv on the host machine. Or it could be either separate target (IMO messy) or some kind of command line option or environment variable so you can select whether you want host or docker (or just default to docker if py3.6 is not found). Thoughts?

[di]

I think it's OK to assume that a Warehouse contributor has Docker installed. However, it's worth noting that Travis currently runs these commands (and the test command) without using a container -- the way it does this is by invoking the bin/tests script directly instead of using the Makefile command, so it is necessary to "preserve" a way to run this without Docker, but it should only be necessary for CI.

[jpurviance]

I am also experiencing issues with this. I am unable to run make lint or make reformat

I manage my interpreters through brew. It recently moved me from 3.6 to 3.7. It would help me and other home-brew users as well if this was in the docker container.

[di]

Now that #9083 is merged, the remaining things that aren't running in containers are:

• make docs
• make deps
• make translations (and it's subcommands)