-
Notifications
You must be signed in to change notification settings - Fork 985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inconsistent requires_dist behavior #6231
Comments
Three things are happening here:
This means that if you upload a source distribution of The first and second points are unlikely to change, but it seems reasonable that a source distribution which deterministically sets |
@di - thanks for the clear explanation! I agree that it would be ideal if |
No problem! Regardless of the outcome of that issue, I don't think there's anything that should change on PyPI's side of things here, so this issue can probably be closed. |
Describe the bug
The following packages both define dependencies in a setup.cfg file:
https://pypi.org/pypi/astropy/json (link to setup.cfg)
https://pypi.org/pypi/glue-vispy-viewers/json (link to setup.cfg)
However, while glue-vispy-viewers seems to have the correct dependencies in
requires_dist
in the JSON meta-data, the same field is empty for astropy.Expected behavior
I would have expected either both cases to work, or neither.
To Reproduce
The URLs above should demonstrate the issue.
Additional context
I have seen in one place someone say something about the order in which packages are uploaded (wheels vs source) but for a package like astropy, where the wheels take a while to build and upload and are uploaded separately, it's difficult to upload the wheels first. Many developers are also not going to be aware of this behavior. So if this is indeed the issue, then if the source file is uploaded first, when the first wheel is uploaded,
requires_dist
should be updated if it wasnull
previously?The text was updated successfully, but these errors were encountered: