Add form field macro

[nlhkabu]

We should consider moving form fields into a reusable macro, to make the template codebase easier to manage.

---

Good First Issue: This issue is good for first time contributors. If you've already contributed to Warehouse, work on another issue without this label instead. If there is not a corresponding pull request for this issue, it is up for grabs. For directions for getting set up, see our Getting Started Guide. If you are working on this issue and have questions, feel free to ask them here, #pypa-dev on Freenode, or the pypa-dev mailing list.

[di]

I've added the "good first issue" label to this issue.

As described in #6370, this would require creating a global Jinja macro to reduce duplication when rendering form fields.

For example, right now we do something like this for every field:

<div class="form-group">
  <label for="full_name" class="form-group__label">Name</label>
  <label for="full_name" class="form-group__label">
    Name
    {% if form.full_name.flags.required %}
    <span class="form-group__required">(required)</span>
    {% endif %}
  </label>
  {{ form.full_name(placeholder="Your name", class_="form-group__input", **{"aria-describedby":"name-errors"}) }}
  {% if form.full_name.errors %}
  <ul id="name-errors" class="form-errors" role="alert">
    {% for error in form.full_name.errors %}
    <li>{{ error }}</li>
    {% endfor %}
  </ul>
  {% endif %}
</div>

This may require finding a way to store the field label on the field definition as well.

[vivekvj18]

@di
@nlhkabu
Can I Take This Task...?

[nlhkabu]

Yes @vivekvj18! Please do :)

[vivekvj18]

@nlhkabu
How Can I Add Form Field Macro Globally...?

[nlhkabu]

You probably want to add the macro in our base template, then use it anywhere we create a form field.

A couple of tutorials I found: https://www.davedash.com/tutorial/jinja-macros/ and https://www.youtube.com/watch?v=sDrGyxDd4qc

[vivekvj18]

@nlhkabu
In The Above PR I Had added macro..
revert me back if it need any changes

[vivekvj18]

Actually i had attached a PR. Kindly check and revert back if it needs any changes

…

On Mon, 11 May 2020, 6:55 pm Nicole Harris, ***@***.***> wrote: You probably want to add the macro in our base template, then use it anywhere we create a form field. A couple of tutorials I found: https://www.davedash.com/tutorial/jinja-macros/ and https://www.youtube.com/watch?v=sDrGyxDd4qc — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#6393 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ANMEEEWDK5EBJVCFUESUHYTRQ74GLANCNFSM4IKGOMYQ> .

[vivekvj18]

@nlhkabu
In The Above PR I Had added macro..
revert me back if it need any changes

[nlhkabu]

Hi @vivekvj18 thank you for your pull requests, we appreciate the time you have taken to contribute to warehouse.

The pull requests you have made both wrap existing code in a macro. Unfortunately, this is not what is needed to address this issue.

What we need to do:

1. Create a new macro. You can see an example of a macro here
2. We then need to find all the places we want to use the macro. For example, we use the macro I linked to above here

In the case of the form field macro, the content will not always be the same, so you will need to define arguments (e.g label, is_required, etc.) and then pass data to these arguments when you use the macro.

You can read the documentation about Jinja macros here. If this is not clear, I suggest you also take some time to watch/read a tutorial on how macros work.

I am going to close your pull requests for now - please open a new pull request when you are ready :)

Thanks again for your contribution.